More platformKeys api tests for the new system token.

More platformKeys api tests for the new system token.

All existing tests are run with the system token disabled and again with the system token enabled. Also are they applied once to the user token and once to the system token.

Additional tests ensure that the tokens don't affect each other.

BUG=210525, 387606
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287227

[Joao da Silva, 2014-07-30 15:29:49]

lgtm

https://codereview.chromium.org/428223003/diff/20001/chrome/test/data/extensi...
File chrome/test/data/extensions/api_test/enterprise_platform_keys/basic.js
(right):

https://codereview.chromium.org/428223003/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/enterprise_platform_keys/basic.js:591:
return result;
How about:

return tests.map(function(test) {
  var bound = test.bind(undefined, token);
  bound.generatedName = test.name;
  return bound;
});

https://codereview.chromium.org/428223003/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/enterprise_platform_keys/basic.js:731:
userToken.id, cert2.buffer, callbackFail('Key not found.'));
Can this be tested with the systemToken too?

[Joao da Silva, 2014-07-30 15:30:03]

Ah, update the CL title and description please :-)

[pneubeck (no reviews), 2014-08-02 19:09:12]

https://codereview.chromium.org/428223003/diff/20001/chrome/test/data/extensi...
File chrome/test/data/extensions/api_test/enterprise_platform_keys/basic.js
(right):

https://codereview.chromium.org/428223003/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/enterprise_platform_keys/basic.js:591:
return result;
On 2014/07/30 15:29:49, Joao da Silva wrote:
> How about:
> 
> return tests.map(function(test) {
>   var bound = test.bind(undefined, token);
>   bound.generatedName = test.name;
>   return bound;
> });

Done.

https://codereview.chromium.org/428223003/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/enterprise_platform_keys/basic.js:731:
userToken.id, cert2.buffer, callbackFail('Key not found.'));
On 2014/07/30 15:29:49, Joao da Silva wrote:
> Can this be tested with the systemToken too?

Done.

[pneubeck (no reviews), 2014-08-02 19:09:20]

The CQ bit was checked by pneubeck@chromium.org

[commit-bot: I haz the power, 2014-08-02 19:09:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pneubeck@chromium.org/428223003/60001

[commit-bot: I haz the power, 2014-08-02 21:03:55]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-02 22:22:46]

Change committed as 287227