Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 428183003: Fix issue with storing 31-bit bitfield as Smi. (Closed)

Created:
6 years, 4 months ago by Yang
Modified:
6 years, 4 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

Fix issue with storing 31-bit bitfield as Smi. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22733

Patch Set 1 #

Patch Set 2 : reverted v8.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M src/code-stubs.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M src/objects.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 4 months ago (2014-07-30 12:57:25 UTC) #1
Sven Panne
LGTM when the v8.h change is reverted
6 years, 4 months ago (2014-07-30 13:17:44 UTC) #2
Sven Panne
LGTM when the v8.h change is reverted
6 years, 4 months ago (2014-07-30 13:17:45 UTC) #3
Yang
6 years, 4 months ago (2014-07-31 07:50:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r22733 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698