Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: components/invalidation/BUILD.gn

Issue 428123002: Revert of components: Fix a couple of the TODO(GYP) todos. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « components/autofill/core/browser/BUILD.gn ('k') | components/policy/core/browser/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 static_library("invalidation") { 5 static_library("invalidation") {
6 sources = [ 6 sources = [
7 "ack_handle.cc", 7 "ack_handle.cc",
8 "ack_handle.h", 8 "ack_handle.h",
9 "ack_handler.cc", 9 "ack_handler.cc",
10 "ack_handler.h", 10 "ack_handler.h",
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 "ticl_settings_provider.cc", 74 "ticl_settings_provider.cc",
75 "ticl_settings_provider.h", 75 "ticl_settings_provider.h",
76 ] 76 ]
77 } 77 }
78 78
79 # TODO(GYP) remove this when libjingle is added. 79 # TODO(GYP) remove this when libjingle is added.
80 configs += [ "//content:libjingle_stub_config" ] 80 configs += [ "//content:libjingle_stub_config" ]
81 81
82 deps = [ 82 deps = [
83 "//base", 83 "//base",
84 "//components/gcm_driver", 84 #"//components/gcm_driver", TODO(GYP)
85 "//google_apis",
85 "//components/keyed_service/core", 86 "//components/keyed_service/core",
87 "//components/signin/core/browser:browser",
86 "//components/pref_registry", 88 "//components/pref_registry",
87 "//components/signin/core/browser", 89 #"//components/signin/core/browser", TODO(GYP)
88 "//google_apis",
89 "//sync", 90 "//sync",
90 "//third_party/cacheinvalidation", 91 "//third_party/cacheinvalidation",
91 #'../jingle/jingle.gyp:notifier', TODO(GYP) 92 #'../jingle/jingle.gyp:notifier', TODO(GYP)
92 93
93 # TODO(sync): Remove this (http://crbug.com/133352); 94 # TODO(sync): Remove this (http://crbug.com/133352);
94 # "//third_party/cacheinvalidation/src/google/cacheinvalidation:cacheinvalid ation_proto_cpp", 95 # "//third_party/cacheinvalidation/src/google/cacheinvalidation:cacheinvalid ation_proto_cpp",
95 ] 96 ]
96 } 97 }
97 98
98 static_library("test_support") { 99 static_library("test_support") {
(...skipping 17 matching lines...) Expand all
116 ] 117 ]
117 if (!is_android) { 118 if (!is_android) {
118 sources += [ 119 sources += [
119 "p2p_invalidation_service.cc", 120 "p2p_invalidation_service.cc",
120 "p2p_invalidation_service.h", 121 "p2p_invalidation_service.h",
121 ] 122 ]
122 } 123 }
123 124
124 deps = [ 125 deps = [
125 "//base", 126 "//base",
126 "//components/gcm_driver:test_support",
127 "//components/keyed_service/core", 127 "//components/keyed_service/core",
128 "//google_apis", 128 "//google_apis",
129 "//net", 129 "//net",
130 "//sync", 130 "//sync",
131 "//testing/gmock", 131 "//testing/gmock",
132 "//third_party/cacheinvalidation", 132 "//third_party/cacheinvalidation",
133 #'../jingle/jingle.gyp:notifier', TODO(GYP) 133 #'../jingle/jingle.gyp:notifier', TODO(GYP)
134 #'../jingle/jingle.gyp:notifier_test_util', TODO(GYP) 134 #'../jingle/jingle.gyp:notifier_test_util', TODO(GYP)
135 #'../sync/sync.gyp:test_support_sync_notifier', TODO(GYP) 135 #'../sync/sync.gyp:test_support_sync_notifier', TODO(GYP)
136 #'gcm_driver_test_support', TODO(GYP)
136 ] 137 ]
137 } 138 }
OLDNEW
« no previous file with comments | « components/autofill/core/browser/BUILD.gn ('k') | components/policy/core/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698