chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc - Issue 428063002: [SyncFS] Replace leveldb classes with LevelDBWrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc

Issue 428063002: [SyncFS] Replace leveldb classes with LevelDBWrapper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase on cl/437943002 Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc ('K') | « chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc ('k') | chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc b/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc

index dca4aecca925c530fc1db8be435b3e95c984e3e8..25a60aed3d5cbe29f514d0373681e3e98fa7f8e7 100644

--- a/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc

+++ b/chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc

@@ -107,9 +107,9 @@ TEST(MetadataDatabaseIndexTest, UpdateTest) {

MetadataDatabaseIndex::CreateForTesting(

CreateTestDatabaseContents().get());

- index->DemoteDirtyTracker(kPlaceholderTrackerID, NULL);

+ index->DemoteDirtyTracker(kPlaceholderTrackerID);

EXPECT_EQ(kInvalidTrackerID, index->PickDirtyTracker());

- index->PromoteDemotedDirtyTrackers(NULL);

+ index->PromoteDemotedDirtyTrackers();

EXPECT_EQ(kPlaceholderTrackerID, index->PickDirtyTracker());

FileMetadata metadata;

@@ -121,14 +121,14 @@ TEST(MetadataDatabaseIndexTest, UpdateTest) {

scoped_ptr<FileTracker> new_tracker =

test_util::CreateTracker(metadata, new_tracker_id, &app_root_tracker);

new_tracker->set_active(false);

- index->StoreFileTracker(new_tracker.Pass(), NULL);

+ index->StoreFileTracker(new_tracker.Pass());

EXPECT_EQ("file_id", index->PickMultiTrackerFileID());

EXPECT_EQ(ParentIDAndTitle(kAppRootTrackerID, std::string("file")),

index->PickMultiBackingFilePath());

- index->RemoveFileMetadata("file_id", NULL);

- index->RemoveFileTracker(kFileTrackerID, NULL);

+ index->RemoveFileMetadata("file_id");

+ index->RemoveFileTracker(kFileTrackerID);

EXPECT_FALSE(index->GetFileMetadata("file_id", NULL));

EXPECT_FALSE(index->GetFileTracker(kFileTrackerID, NULL));