Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2767)

Unified Diff: chrome/browser/sync_file_system/drive_backend/metadata_database.h

Issue 428063002: [SyncFS] Replace leveldb classes with LevelDBWrapper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase on cl/437943002 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/drive_backend/metadata_database.h
diff --git a/chrome/browser/sync_file_system/drive_backend/metadata_database.h b/chrome/browser/sync_file_system/drive_backend/metadata_database.h
index 6d868d3eb3859b407527f33f8f4ffd3130d617a6..cfd745d94ece7a99ac2d1b8b77c8575b8fa07d33 100644
--- a/chrome/browser/sync_file_system/drive_backend/metadata_database.h
+++ b/chrome/browser/sync_file_system/drive_backend/metadata_database.h
@@ -29,9 +29,7 @@ class SingleThreadTaskRunner;
}
namespace leveldb {
-class DB;
class Env;
-class WriteBatch;
}
namespace google_apis {
@@ -50,6 +48,7 @@ namespace drive_backend {
class FileDetails;
class FileMetadata;
class FileTracker;
+class LevelDBWrapper;
class MetadataDatabaseIndexInterface;
class ServiceMetadata;
@@ -138,7 +137,7 @@ class MetadataDatabase {
leveldb::Env* env_override,
const CreateCallback& callback);
static SyncStatusCode CreateForTesting(
- scoped_ptr<leveldb::DB> db,
+ scoped_ptr<LevelDBWrapper> db,
scoped_ptr<MetadataDatabase>* metadata_database_out);
~MetadataDatabase();
@@ -358,27 +357,22 @@ class MetadataDatabase {
// Database manipulation methods.
void RegisterTrackerAsAppRoot(const std::string& app_id,
- int64 tracker_id,
- leveldb::WriteBatch* batch);
+ int64 tracker_id);
void CreateTrackerForParentAndFileID(const FileTracker& parent_tracker,
- const std::string& file_id,
- leveldb::WriteBatch* batch);
+ const std::string& file_id);
void CreateTrackerForParentAndFileMetadata(const FileTracker& parent_tracker,
const FileMetadata& file_metadata,
- UpdateOption option,
- leveldb::WriteBatch* batch);
+ UpdateOption option);
void CreateTrackerInternal(const FileTracker& parent_tracker,
const std::string& file_id,
const FileDetails* details,
- UpdateOption option,
- leveldb::WriteBatch* batch);
+ UpdateOption option);
void MaybeAddTrackersForNewFile(const FileMetadata& file,
- UpdateOption option,
- leveldb::WriteBatch* batch);
+ UpdateOption option);
- int64 IncrementTrackerID(leveldb::WriteBatch* batch);
+ int64 IncrementTrackerID();
bool CanActivateTracker(const FileTracker& tracker);
bool ShouldKeepDirty(const FileTracker& tracker) const;
@@ -388,37 +382,31 @@ class MetadataDatabase {
bool HasActiveTrackerForPath(int64 parent_tracker,
const std::string& title) const;
- void RemoveUnneededTrackersForMissingFile(const std::string& file_id,
- leveldb::WriteBatch* batch);
+ void RemoveUnneededTrackersForMissingFile(const std::string& file_id);
void UpdateByFileMetadata(const tracked_objects::Location& from_where,
scoped_ptr<FileMetadata> file,
- UpdateOption option,
- leveldb::WriteBatch* batch);
+ UpdateOption option);
- void WriteToDatabase(scoped_ptr<leveldb::WriteBatch> batch,
- const SyncStatusCallback& callback);
+ void WriteToDatabase(const SyncStatusCallback& callback);
bool HasNewerFileMetadata(const std::string& file_id, int64 change_id);
scoped_ptr<base::ListValue> DumpTrackers();
scoped_ptr<base::ListValue> DumpMetadata();
- void AttachSyncRoot(const google_apis::FileResource& sync_root_folder,
- leveldb::WriteBatch* batch);
- void AttachInitialAppRoot(const google_apis::FileResource& app_root_folder,
- leveldb::WriteBatch* batch);
+ void AttachSyncRoot(const google_apis::FileResource& sync_root_folder);
+ void AttachInitialAppRoot(const google_apis::FileResource& app_root_folder);
void ForceActivateTrackerByPath(int64 parent_tracker_id,
const std::string& title,
- const std::string& file_id,
- leveldb::WriteBatch* batch);
+ const std::string& file_id);
void DetachFromSequence();
scoped_refptr<base::SequencedTaskRunner> worker_task_runner_;
base::FilePath database_path_;
leveldb::Env* env_override_;
- scoped_ptr<leveldb::DB> db_;
+ scoped_ptr<LevelDBWrapper> db_;
int64 largest_known_change_id_;

Powered by Google App Engine
This is Rietveld 408576698