Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 428013002: GN: Use rsp file, not rsp file contents, in solink line (Closed)

Created:
6 years, 4 months ago by jamesr
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, cjhopman
Project:
chromium
Visibility:
Public.

Description

GN: Use rsp file, not rsp file contents, in solink line Passing $rspfile_content passes the content of the rsp file verbatim to the command line, which kind of defeats the purpose of using rsp files. @\$rspfile tells the linker to open up the file itself. BUG=398255 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/toolchain/gcc_toolchain.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
jamesr
6 years, 4 months ago (2014-07-29 23:52:42 UTC) #1
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-07-29 23:52:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/428013002/1
6 years, 4 months ago (2014-07-29 23:57:26 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 23:57:27 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-07-29 23:57:27 UTC) #5
brettw
ooh, clever! LGTM
6 years, 4 months ago (2014-07-30 22:22:27 UTC) #6
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-07-30 22:32:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/428013002/1
6 years, 4 months ago (2014-07-30 22:33:19 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 01:33:35 UTC) #9
Message was sent while issue was closed.
Change committed as 286675

Powered by Google App Engine
This is Rietveld 408576698