Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 427893002: add is_gs_url(), split_gs_url() static methods to gs_utils.py (Closed)

Created:
6 years, 4 months ago by epoger
Modified:
6 years, 4 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/common.git@master
Visibility:
Public.

Description

add is_gs_url(), split_gs_url() static methods to gs_utils.py This will be helpful for dealing with user input in the gs://path format. R=rmistry@google.com Committed: https://skia.googlesource.com/common/+/f63e1cf

Patch Set 1 #

Total comments: 4

Patch Set 2 : Ravi comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
M py/utils/gs_utils.py View 1 2 chunks +30 lines, -0 lines 0 comments Download
M py/utils/gs_utils_manualtest.py View 1 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
epoger
Ravi, PTAL at patchset 1
6 years, 4 months ago (2014-07-29 20:14:14 UTC) #1
rmistry
LGTM https://codereview.chromium.org/427893002/diff/1/py/utils/gs_utils_manualtest.py File py/utils/gs_utils_manualtest.py (right): https://codereview.chromium.org/427893002/diff/1/py/utils/gs_utils_manualtest.py#newcode60 py/utils/gs_utils_manualtest.py:60: ('gs://bucket/path1', 'bucket', 'path1'), Could you also please add ...
6 years, 4 months ago (2014-07-29 20:36:20 UTC) #2
epoger
Thanks, fixes at patchset 2. Committing now. https://codereview.chromium.org/427893002/diff/1/py/utils/gs_utils_manualtest.py File py/utils/gs_utils_manualtest.py (right): https://codereview.chromium.org/427893002/diff/1/py/utils/gs_utils_manualtest.py#newcode60 py/utils/gs_utils_manualtest.py:60: ('gs://bucket/path1', 'bucket', ...
6 years, 4 months ago (2014-07-30 01:10:49 UTC) #3
epoger
6 years, 4 months ago (2014-07-30 01:11:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as rf63e1cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698