src/x64/assembler-x64.h - Issue 427863003: Abstract out fetching of break_address in debug mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64.h

Issue 427863003: Abstract out fetching of break_address in debug mode (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: update to catch 2nd usage Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/assembler-x64.h

diff --git a/src/x64/assembler-x64.h b/src/x64/assembler-x64.h

index 4259e9b50ef5ccbfd5d5b8f2452b6052697a5543..686b07a4527a660703e78306aa04c8ea7fe2e2c2 100644

--- a/src/x64/assembler-x64.h

+++ b/src/x64/assembler-x64.h

@@ -592,6 +592,9 @@ class Assembler : public AssemblerBase {

static const int kRealPatchReturnSequenceAddressOffset =

kMoveAddressIntoScratchRegisterInstructionLength - kPointerSize;

+ // Return the code target address of the patch debug break slot

+ inline static Address break_address_from_break_address(Address pc);

// One byte opcode for test eax,0xXXXXXXXX.

static const byte kTestEaxByte = 0xA9;

// One byte opcode for test al, 0xXX.