src/ia32/assembler-ia32.h - Issue 427863003: Abstract out fetching of break_address in debug mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/assembler-ia32.h

Issue 427863003: Abstract out fetching of break_address in debug mode (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: update to catch 2nd usage Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/assembler-ia32.h

diff --git a/src/ia32/assembler-ia32.h b/src/ia32/assembler-ia32.h

index de8b04f84e3e27287eaf0175d322545f1ce9cc3b..f63af9387551c85db6ac7282e6066de14d2e8cd3 100644

--- a/src/ia32/assembler-ia32.h

+++ b/src/ia32/assembler-ia32.h

@@ -533,6 +533,9 @@ class Assembler : public AssemblerBase {

// to jump to.

static const int kPatchDebugBreakSlotAddressOffset = 1; // JMP imm32.

+ // Return the code target address of the patch debug break slot

+ inline static Address break_address_from_break_address(Address pc);

static const int kCallInstructionLength = 5;

static const int kPatchDebugBreakSlotReturnOffset = kPointerSize;

static const int kJSReturnSequenceLength = 6;