Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/x87/assembler-x87.h

Issue 427863003: Abstract out fetching of break_address in debug mode (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: address formatting comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | src/x87/assembler-x87-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 ICacheFlushMode icache_flush_mode = 495 ICacheFlushMode icache_flush_mode =
496 FLUSH_ICACHE_IF_NEEDED) { 496 FLUSH_ICACHE_IF_NEEDED) {
497 ConstantPoolArray* constant_pool = code ? code->constant_pool() : NULL; 497 ConstantPoolArray* constant_pool = code ? code->constant_pool() : NULL;
498 set_target_address_at(pc, constant_pool, target); 498 set_target_address_at(pc, constant_pool, target);
499 } 499 }
500 500
501 // Return the code target address at a call site from the return address 501 // Return the code target address at a call site from the return address
502 // of that call in the instruction stream. 502 // of that call in the instruction stream.
503 inline static Address target_address_from_return_address(Address pc); 503 inline static Address target_address_from_return_address(Address pc);
504 504
505 // Return the code target address of the patch debug break slot
506 inline static Address break_address_from_return_address(Address pc);
507
505 // This sets the branch destination (which is in the instruction on x86). 508 // This sets the branch destination (which is in the instruction on x86).
506 // This is for calls and branches within generated code. 509 // This is for calls and branches within generated code.
507 inline static void deserialization_set_special_target_at( 510 inline static void deserialization_set_special_target_at(
508 Address instruction_payload, Code* code, Address target) { 511 Address instruction_payload, Code* code, Address target) {
509 set_target_address_at(instruction_payload, code, target); 512 set_target_address_at(instruction_payload, code, target);
510 } 513 }
511 514
512 static const int kSpecialTargetSize = kPointerSize; 515 static const int kSpecialTargetSize = kPointerSize;
513 516
514 // Distance between the address of the code target in the call instruction 517 // Distance between the address of the code target in the call instruction
(...skipping 507 matching lines...) Expand 10 before | Expand all | Expand 10 after
1022 private: 1025 private:
1023 Assembler* assembler_; 1026 Assembler* assembler_;
1024 #ifdef DEBUG 1027 #ifdef DEBUG
1025 int space_before_; 1028 int space_before_;
1026 #endif 1029 #endif
1027 }; 1030 };
1028 1031
1029 } } // namespace v8::internal 1032 } } // namespace v8::internal
1030 1033
1031 #endif // V8_X87_ASSEMBLER_X87_H_ 1034 #endif // V8_X87_ASSEMBLER_X87_H_
OLDNEW
« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | src/x87/assembler-x87-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698