Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Side by Side Diff: src/x64/assembler-x64.h

Issue 427863003: Abstract out fetching of break_address in debug mode (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: address formatting comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips64/assembler-mips64-inl.h ('k') | src/x64/assembler-x64-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 520 matching lines...) Expand 10 before | Expand all | Expand 10 after
531 ICacheFlushMode icache_flush_mode = 531 ICacheFlushMode icache_flush_mode =
532 FLUSH_ICACHE_IF_NEEDED) { 532 FLUSH_ICACHE_IF_NEEDED) {
533 ConstantPoolArray* constant_pool = code ? code->constant_pool() : NULL; 533 ConstantPoolArray* constant_pool = code ? code->constant_pool() : NULL;
534 set_target_address_at(pc, constant_pool, target, icache_flush_mode); 534 set_target_address_at(pc, constant_pool, target, icache_flush_mode);
535 } 535 }
536 536
537 // Return the code target address at a call site from the return address 537 // Return the code target address at a call site from the return address
538 // of that call in the instruction stream. 538 // of that call in the instruction stream.
539 static inline Address target_address_from_return_address(Address pc); 539 static inline Address target_address_from_return_address(Address pc);
540 540
541 // Return the code target address of the patch debug break slot
542 inline static Address break_address_from_return_address(Address pc);
543
541 // This sets the branch destination (which is in the instruction on x64). 544 // This sets the branch destination (which is in the instruction on x64).
542 // This is for calls and branches within generated code. 545 // This is for calls and branches within generated code.
543 inline static void deserialization_set_special_target_at( 546 inline static void deserialization_set_special_target_at(
544 Address instruction_payload, Code* code, Address target) { 547 Address instruction_payload, Code* code, Address target) {
545 set_target_address_at(instruction_payload, code, target); 548 set_target_address_at(instruction_payload, code, target);
546 } 549 }
547 550
548 static inline RelocInfo::Mode RelocInfoNone() { 551 static inline RelocInfo::Mode RelocInfoNone() {
549 if (kPointerSize == kInt64Size) { 552 if (kPointerSize == kInt64Size) {
550 return RelocInfo::NONE64; 553 return RelocInfo::NONE64;
(...skipping 1030 matching lines...) Expand 10 before | Expand all | Expand 10 after
1581 private: 1584 private:
1582 Assembler* assembler_; 1585 Assembler* assembler_;
1583 #ifdef DEBUG 1586 #ifdef DEBUG
1584 int space_before_; 1587 int space_before_;
1585 #endif 1588 #endif
1586 }; 1589 };
1587 1590
1588 } } // namespace v8::internal 1591 } } // namespace v8::internal
1589 1592
1590 #endif // V8_X64_ASSEMBLER_X64_H_ 1593 #endif // V8_X64_ASSEMBLER_X64_H_
OLDNEW
« no previous file with comments | « src/mips64/assembler-mips64-inl.h ('k') | src/x64/assembler-x64-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698