Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: src/ia32/assembler-ia32.h

Issue 427863003: Abstract out fetching of break_address in debug mode (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: address formatting comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/debug.cc ('k') | src/ia32/assembler-ia32-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 495 matching lines...) Expand 10 before | Expand all | Expand 10 after
506 ICacheFlushMode icache_flush_mode = 506 ICacheFlushMode icache_flush_mode =
507 FLUSH_ICACHE_IF_NEEDED) { 507 FLUSH_ICACHE_IF_NEEDED) {
508 ConstantPoolArray* constant_pool = code ? code->constant_pool() : NULL; 508 ConstantPoolArray* constant_pool = code ? code->constant_pool() : NULL;
509 set_target_address_at(pc, constant_pool, target); 509 set_target_address_at(pc, constant_pool, target);
510 } 510 }
511 511
512 // Return the code target address at a call site from the return address 512 // Return the code target address at a call site from the return address
513 // of that call in the instruction stream. 513 // of that call in the instruction stream.
514 inline static Address target_address_from_return_address(Address pc); 514 inline static Address target_address_from_return_address(Address pc);
515 515
516 // Return the code target address of the patch debug break slot
517 inline static Address break_address_from_return_address(Address pc);
518
516 // This sets the branch destination (which is in the instruction on x86). 519 // This sets the branch destination (which is in the instruction on x86).
517 // This is for calls and branches within generated code. 520 // This is for calls and branches within generated code.
518 inline static void deserialization_set_special_target_at( 521 inline static void deserialization_set_special_target_at(
519 Address instruction_payload, Code* code, Address target) { 522 Address instruction_payload, Code* code, Address target) {
520 set_target_address_at(instruction_payload, code, target); 523 set_target_address_at(instruction_payload, code, target);
521 } 524 }
522 525
523 static const int kSpecialTargetSize = kPointerSize; 526 static const int kSpecialTargetSize = kPointerSize;
524 527
525 // Distance between the address of the code target in the call instruction 528 // Distance between the address of the code target in the call instruction
(...skipping 634 matching lines...) Expand 10 before | Expand all | Expand 10 after
1160 private: 1163 private:
1161 Assembler* assembler_; 1164 Assembler* assembler_;
1162 #ifdef DEBUG 1165 #ifdef DEBUG
1163 int space_before_; 1166 int space_before_;
1164 #endif 1167 #endif
1165 }; 1168 };
1166 1169
1167 } } // namespace v8::internal 1170 } } // namespace v8::internal
1168 1171
1169 #endif // V8_IA32_ASSEMBLER_IA32_H_ 1172 #endif // V8_IA32_ASSEMBLER_IA32_H_
OLDNEW
« no previous file with comments | « src/debug.cc ('k') | src/ia32/assembler-ia32-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698