Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: src/mips/assembler-mips.h

Issue 427863003: Abstract out fetching of break_address in debug mode (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: update to catch 2nd usage Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
554 static const int kCallTargetAddressOffset = 4 * kInstrSize; 554 static const int kCallTargetAddressOffset = 4 * kInstrSize;
555 555
556 // Distance between start of patched return sequence and the emitted address 556 // Distance between start of patched return sequence and the emitted address
557 // to jump to. 557 // to jump to.
558 static const int kPatchReturnSequenceAddressOffset = 0; 558 static const int kPatchReturnSequenceAddressOffset = 0;
559 559
560 // Distance between start of patched debug break slot and the emitted address 560 // Distance between start of patched debug break slot and the emitted address
561 // to jump to. 561 // to jump to.
562 static const int kPatchDebugBreakSlotAddressOffset = 0 * kInstrSize; 562 static const int kPatchDebugBreakSlotAddressOffset = 0 * kInstrSize;
563 563
564 // Return the code target address of the patch debug break slot
565 inline static Address break_address_from_break_address(Address pc);
566
564 // Difference between address of current opcode and value read from pc 567 // Difference between address of current opcode and value read from pc
565 // register. 568 // register.
566 static const int kPcLoadDelta = 4; 569 static const int kPcLoadDelta = 4;
567 570
568 static const int kPatchDebugBreakSlotReturnOffset = 4 * kInstrSize; 571 static const int kPatchDebugBreakSlotReturnOffset = 4 * kInstrSize;
569 572
570 // Number of instructions used for the JS return sequence. The constant is 573 // Number of instructions used for the JS return sequence. The constant is
571 // used by the debugger to patch the JS return sequence. 574 // used by the debugger to patch the JS return sequence.
572 static const int kJSReturnSequenceInstructions = 7; 575 static const int kJSReturnSequenceInstructions = 7;
573 static const int kDebugBreakSlotInstructions = 4; 576 static const int kDebugBreakSlotInstructions = 4;
(...skipping 660 matching lines...) Expand 10 before | Expand all | Expand 10 after
1234 class EnsureSpace BASE_EMBEDDED { 1237 class EnsureSpace BASE_EMBEDDED {
1235 public: 1238 public:
1236 explicit EnsureSpace(Assembler* assembler) { 1239 explicit EnsureSpace(Assembler* assembler) {
1237 assembler->CheckBuffer(); 1240 assembler->CheckBuffer();
1238 } 1241 }
1239 }; 1242 };
1240 1243
1241 } } // namespace v8::internal 1244 } } // namespace v8::internal
1242 1245
1243 #endif // V8_ARM_ASSEMBLER_MIPS_H_ 1246 #endif // V8_ARM_ASSEMBLER_MIPS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698