Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 427853004: Move libdrm target behind conditional (Closed)

Created:
6 years, 4 months ago by dnicoara
Modified:
6 years, 4 months ago
Reviewers:
brettw, spang
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move libdrm target behind conditional On embedded platforms the library may not be available. As-is GYP will try running pkg-config early on even if none of the Ozone dependencies require libdrm. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286855

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -23 lines) Patch
M build/config/linux/BUILD.gn View 1 1 chunk +0 lines, -4 lines 0 comments Download
M build/linux/system.gyp View 1 2 3 2 chunks +18 lines, -14 lines 0 comments Download
M ui/ozone/platform/dri/BUILD.gn View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/dri.gypi View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/gbm.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
dnicoara
PTAL
6 years, 4 months ago (2014-07-29 21:36:51 UTC) #1
spang
lgtm https://codereview.chromium.org/427853004/diff/20001/build/linux/system.gyp File build/linux/system.gyp (right): https://codereview.chromium.org/427853004/diff/20001/build/linux/system.gyp#newcode422 build/linux/system.gyp:422: 'target_name': 'dridrm', while you're here, fix the name. ...
6 years, 4 months ago (2014-07-29 21:43:03 UTC) #2
dnicoara
Thanks! https://codereview.chromium.org/427853004/diff/20001/build/linux/system.gyp File build/linux/system.gyp (right): https://codereview.chromium.org/427853004/diff/20001/build/linux/system.gyp#newcode422 build/linux/system.gyp:422: 'target_name': 'dridrm', On 2014/07/29 21:43:03, spang wrote: > ...
6 years, 4 months ago (2014-07-29 21:50:49 UTC) #3
dnicoara
+ brettw@ for build/config OWNERS
6 years, 4 months ago (2014-07-29 21:51:30 UTC) #4
brettw
lgtm
6 years, 4 months ago (2014-07-30 22:25:01 UTC) #5
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 4 months ago (2014-07-31 01:16:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/427853004/60001
6 years, 4 months ago (2014-07-31 01:19:10 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-31 01:25:45 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 01:29:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/1138) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/1026) win8_chromium_rel ...
6 years, 4 months ago (2014-07-31 01:29:15 UTC) #10
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 4 months ago (2014-07-31 14:31:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/427853004/80001
6 years, 4 months ago (2014-07-31 14:32:28 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium.win ...
6 years, 4 months ago (2014-07-31 18:01:15 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 18:31:52 UTC) #14
Message was sent while issue was closed.
Change committed as 286855

Powered by Google App Engine
This is Rietveld 408576698