DevTools: nits: introduce a handy asBool(bool*) and use across agents.

Source/core/inspector/InspectorPageAgent.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 526 matching lines @@
         *error = "Script not found";
         return;
     }
     scripts->remove(identifier);
 }
 
 void InspectorPageAgent::reload(ErrorString*, const bool* const optionalIgnoreCache, const String* optionalScriptToEvaluateOnLoad, const String* optionalScriptPreprocessor)
 {
     m_pendingScriptToEvaluateOnLoadOnce = optionalScriptToEvaluateOnLoad ? *optionalScriptToEvaluateOnLoad : "";
     m_pendingScriptPreprocessor = optionalScriptPreprocessor ? *optionalScriptPreprocessor : "";
-    m_page->deprecatedLocalMainFrame()->loader().reload(optionalIgnoreCache && *optionalIgnoreCache ? EndToEndReload : NormalReload);
+    m_page->deprecatedLocalMainFrame()->loader().reload(asBool(optionalIgnoreCache) ? EndToEndReload : NormalReload);
 }
 
 void InspectorPageAgent::navigate(ErrorString*, const String& url, String* outFrameId)
 {
     LocalFrame* frame = m_page->deprecatedLocalMainFrame();
     *outFrameId = frameId(frame);
 }
 
 static PassRefPtr<TypeBuilder::Page::Cookie> buildObjectForCookie(const Cookie& cookie)
 {
@@ skipping 174 matching lines @@
             return true;
         }
     }
     return false;
 }
 
 void InspectorPageAgent::searchInResource(ErrorString*, const String& frameId, const String& url, const String& query, const bool* const optionalCaseSensitive, const bool* const optionalIsRegex, RefPtr<TypeBuilder::Array<TypeBuilder::Page::SearchMatch> >& results)
 {
     results = TypeBuilder::Array<TypeBuilder::Page::SearchMatch>::create();
 
-    bool isRegex = optionalIsRegex ? *optionalIsRegex : false;
-    bool caseSensitive = optionalCaseSensitive ? *optionalCaseSensitive : false;
-
     LocalFrame* frame = frameForId(frameId);
     KURL kurl(ParsedURLString, url);
 
     FrameLoader* frameLoader = frame ? &frame->loader() : 0;
     DocumentLoader* loader = frameLoader ? frameLoader->documentLoader() : 0;
     if (!loader)
         return;
 
     String content;
     bool success = false;
     Resource* resource = cachedResource(frame, kurl);
     if (resource)
         success = textContentForResource(resource, &content);
 
     if (!success)
         return;
 
-    results = ContentSearchUtils::searchInTextByLines(content, query, caseSensitive, isRegex);
+    results = ContentSearchUtils::searchInTextByLines(content, query, asBool(optionalCaseSensitive), asBool(optionalIsRegex));
 }
 
 void InspectorPageAgent::setDocumentContent(ErrorString* errorString, const String& frameId, const String& html)
 {
     LocalFrame* frame = assertFrame(errorString, frameId);
     if (!frame)
         return;
 
     Document* document = frame->document();
     if (!document) {
@@ skipping 625 matching lines @@
         if (errorString)
             *errorString = "Compositing mode is not supported";
         return false;
     }
     return true;
 }
 
 void InspectorPageAgent::setShowViewportSizeOnResize(ErrorString*, bool show, const bool* showGrid)
 {
     m_state->setBoolean(PageAgentState::showSizeOnResize, show);
-    m_state->setBoolean(PageAgentState::showGridOnResize, showGrid && *showGrid);
+    m_state->setBoolean(PageAgentState::showGridOnResize, asBool(showGrid));
 }
 
 void InspectorPageAgent::clearEditedResourcesContent()
 {
     m_editedResourceContent.clear();
 }
 
 void InspectorPageAgent::addEditedResourceContent(const String& url, const String& content)
 {
     m_editedResourceContent.set(url, content);
 }
 
 bool InspectorPageAgent::getEditedResourceContent(const String& url, String* content)
 {
     if (!m_editedResourceContent.contains(url))
         return false;
     *content = m_editedResourceContent.get(url);
     return true;
 }
 
 void InspectorPageAgent::trace(Visitor* visitor)
 {
     visitor->trace(m_page);
     visitor->trace(m_injectedScriptManager);
     InspectorBaseAgent::trace(visitor);
 }
 
 } // namespace blink