Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 427763002: Revert of "Clang roll 209387:214024" (Closed)

Created:
6 years, 4 months ago by alancutter (OOO until 2018)
Modified:
6 years, 4 months ago
Reviewers:
hans, Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of "Clang roll 209387:214024" Reason for revert: Clang roll caused release build of Blink test runner to start crashing on the following layout tests: fast/text-autosizing/constrained-floats.html fast/text-autosizing/form-controls-autosizing-button-input-elements.html fast/text-autosizing/form-controls-autosizing-fieldset-element.html fast/text-autosizing/form-controls-autosizing-select-element.html Original issue's description: > Clang roll 209387:214024 > > BUG=381489 > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286068 TBR=hans@chromium.org,thakis@chromium.org NOTREECHECKS=true NOTRY=true BUG=398348 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286153

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M tools/clang/blink_gc_plugin/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/update.sh View 1 chunk +1 line, -1 line 0 comments Download
D tools/whitespace.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
6 years, 4 months ago (2014-07-29 09:51:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/427763002/1
6 years, 4 months ago (2014-07-29 09:51:49 UTC) #2
commit-bot: I haz the power
Change committed as 286153
6 years, 4 months ago (2014-07-29 09:53:39 UTC) #3
hans
Sorry about the breakage, and thanks for reverting. On which bot were the tests crashing? ...
6 years, 4 months ago (2014-07-29 16:15:23 UTC) #4
hans
On 2014/07/29 16:15:23, hans wrote: > On which bot were the tests crashing? Linux? Mac? ...
6 years, 4 months ago (2014-07-29 16:48:24 UTC) #5
alancutter (OOO until 2018)
On 2014/07/29 16:48:24, hans wrote: > On 2014/07/29 16:15:23, hans wrote: > > On which ...
6 years, 4 months ago (2014-07-30 00:50:39 UTC) #6
Nico
6 years, 4 months ago (2014-07-30 00:57:42 UTC) #7
On Tue, Jul 29, 2014 at 5:50 PM, <alancutter@chromium.org> wrote:

> On 2014/07/29 16:48:24, hans wrote:
>
>> On 2014/07/29 16:15:23, hans wrote:
>> > On which bot were the tests crashing? Linux? Mac? Everywhere?
>>
>
>  Never mind, I can reproduce this on Linux.
>>
>
> Sorry should have specified. Just the Linux and Mac release builds, debug
> and
> Windows unaffected.
> http://i.imgur.com/3WXBiu2.png


Ideally include a link to 1-3 failing bots in the revert message. (In this
case it wasn't an issue though.)


>
>
> https://codereview.chromium.org/427763002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698