Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: content/browser/ssl/ssl_client_auth_handler.h

Issue 42773002: Get ClientCertStore through ResourceContext. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: changes for comments #4 and #5 Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/ssl/ssl_client_auth_handler.h
diff --git a/content/browser/ssl/ssl_client_auth_handler.h b/content/browser/ssl/ssl_client_auth_handler.h
index 9bd8275652585b53ed9e35cdab49cbe63f20bfac..d21bb4b5f342eeddc5bc5a04ccf372629f1a8deb 100644
--- a/content/browser/ssl/ssl_client_auth_handler.h
+++ b/content/browser/ssl/ssl_client_auth_handler.h
@@ -13,6 +13,7 @@
#include "net/ssl/ssl_cert_request_info.h"
namespace net {
+class ClientCertStore;
class HttpNetworkSession;
class URLRequest;
class X509Certificate;
@@ -20,6 +21,8 @@ class X509Certificate;
namespace content {
+class ResourceContext;
+
// This class handles the approval and selection of a certificate for SSL client
// authentication by the user.
// It is self-owned and deletes itself when the UI reports the user selection or
@@ -28,7 +31,8 @@ class CONTENT_EXPORT SSLClientAuthHandler
: public base::RefCountedThreadSafe<
SSLClientAuthHandler, BrowserThread::DeleteOnIOThread> {
public:
- SSLClientAuthHandler(net::URLRequest* request,
+ SSLClientAuthHandler(ResourceContext* context,
wtc 2013/10/28 19:41:12 It may be better to just pass the ClientCertStore
mattm 2013/10/28 23:56:16 Done.
+ net::URLRequest* request,
net::SSLCertRequestInfo* cert_request_info);
// Selects a certificate and resumes the URL request with that certificate.
@@ -53,6 +57,9 @@ class CONTENT_EXPORT SSLClientAuthHandler
friend class BrowserThread;
friend class base::DeleteHelper<SSLClientAuthHandler>;
+ // Called when ClientCertStore is done retrieving the cert list.
+ void GotClientCerts();
wtc 2013/10/28 19:41:12 Nit: our naming convention for this kind of functi
mattm 2013/10/28 23:56:16 Done.
+
// Notifies that the user has selected a cert.
// Called on the IO thread.
void DoCertificateSelected(net::X509Certificate* cert);
@@ -70,6 +77,8 @@ class CONTENT_EXPORT SSLClientAuthHandler
// The certs to choose from.
scoped_refptr<net::SSLCertRequestInfo> cert_request_info_;
+ scoped_ptr<net::ClientCertStore> client_cert_store_;
+
DISALLOW_COPY_AND_ASSIGN(SSLClientAuthHandler);
};

Powered by Google App Engine
This is Rietveld 408576698