Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1673)

Unified Diff: net/ssl/client_cert_store.h

Issue 42773002: Get ClientCertStore through ResourceContext. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: changes for comment #7 Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/ssl/client_cert_store.h
diff --git a/net/ssl/client_cert_store.h b/net/ssl/client_cert_store.h
index 46ef3362b3bbcc6aa4c67fa88fcd85bc04a22eeb..ea1afb0faf2c3296f5e829aaa52650068bbaf6f6 100644
--- a/net/ssl/client_cert_store.h
+++ b/net/ssl/client_cert_store.h
@@ -6,6 +6,7 @@
#define NET_SSL_CLIENT_CERT_STORE_H_
#include "base/basictypes.h"
+#include "base/callback_forward.h"
#include "net/base/net_export.h"
#include "net/cert/x509_certificate.h"
@@ -13,12 +14,18 @@ namespace net {
class SSLCertRequestInfo;
+// The caller is expected to keep the ClientCertStore alive until the callback
+// supplied to GetClientCerts has been run.
class NET_EXPORT ClientCertStore {
public:
virtual ~ClientCertStore() {}
- virtual bool GetClientCerts(const SSLCertRequestInfo& cert_request_info,
- CertificateList* selected_certs) = 0;
+ // Get client certs matching the |cert_request_info|. On completion, the
+ // results will be stored in |selected_certs| and the |callback| will be run.
+ // The |callback| may be called sychronously.
wtc 2013/10/29 23:03:12 This implies the memory that |selected_certs| poin
mattm 2013/10/29 23:59:01 Yeah. I'll update comment to make that explicit to
+ virtual void GetClientCerts(const SSLCertRequestInfo& cert_request_info,
+ CertificateList* selected_certs,
+ const base::Closure& callback) = 0;
protected:
ClientCertStore() {}

Powered by Google App Engine
This is Rietveld 408576698