Issue 427723005: Stop using -Wno-sentinel with clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 427723005: Stop using -Wno-sentinel with clang. (Closed)

Created:
6 years, 4 months ago by Nico

Modified:
6 years, 4 months ago

Reviewers:
Dai Mikurube (NOT FULLTIME)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Stop using -Wno-sentinel with clang. Clang works fine with -Wsentinel on 32bit linux these days. BUG=162818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287061

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	build/common.gypi	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/427723005/1

6 years, 4 months ago (2014-08-01 04:07:13 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...

6 years, 4 months ago (2014-08-01 11:19:43 UTC) #5

erikchen

6 years, 4 months ago (2014-08-01 20:11:39 UTC) #7

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/431393002/ by erikchen@chromium.org.

The reason for reverting is: breaks Google Chrome Linux

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/....

Expand Messages | Collapse Messages