Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Side by Side Diff: test/mjsunit/builtins.js

Issue 427723002: Enable ES6 Map and Set by default (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove old test, fix BUILD.gn Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-ordered-hash-table.cc ('k') | test/mjsunit/debug-script.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 20 matching lines...) Expand all
31 // constructors (recognized by having properties on their .prototype object), 31 // constructors (recognized by having properties on their .prototype object),
32 // have only unconfigurable properties on the prototype, and the methods 32 // have only unconfigurable properties on the prototype, and the methods
33 // are also non-writable. 33 // are also non-writable.
34 34
35 var names = Object.getOwnPropertyNames(builtins); 35 var names = Object.getOwnPropertyNames(builtins);
36 36
37 function isFunction(obj) { 37 function isFunction(obj) {
38 return typeof obj == "function"; 38 return typeof obj == "function";
39 } 39 }
40 40
41 function isV8Native(name) {
42 return name == "GeneratorFunctionPrototype" ||
43 name == "SetIterator" ||
44 name == "MapIterator";
45 }
46
41 function checkConstructor(func, name) { 47 function checkConstructor(func, name) {
42 // A constructor is a function with a prototype and properties on the 48 // A constructor is a function with a prototype and properties on the
43 // prototype object besides "constructor"; 49 // prototype object besides "constructor";
44 if (name.charAt(0) == "$") return; 50 if (name.charAt(0) == "$") return;
45 if (typeof func.prototype != "object") return; 51 if (typeof func.prototype != "object") return;
46 var propNames = Object.getOwnPropertyNames(func.prototype); 52 var propNames = Object.getOwnPropertyNames(func.prototype);
47 if (propNames.length == 0 || 53 if (propNames.length == 0 ||
48 (propNames.length == 1 && propNames[0] == "constructor")) { 54 (propNames.length == 1 && propNames[0] == "constructor")) {
49 // Not a constructor. 55 // Not a constructor.
50 return; 56 return;
51 } 57 }
52 var proto_desc = Object.getOwnPropertyDescriptor(func, "prototype"); 58 var proto_desc = Object.getOwnPropertyDescriptor(func, "prototype");
53 assertTrue(proto_desc.hasOwnProperty("value"), name); 59 assertTrue(proto_desc.hasOwnProperty("value"), name);
54 assertFalse(proto_desc.writable, name); 60 assertFalse(proto_desc.writable, name);
55 assertFalse(proto_desc.configurable, name); 61 assertFalse(proto_desc.configurable, name);
56 var prototype = proto_desc.value; 62 var prototype = proto_desc.value;
57 assertEquals(name == "GeneratorFunctionPrototype" ? Object.prototype : null, 63 assertEquals(isV8Native(name) ? Object.prototype : null,
58 Object.getPrototypeOf(prototype), 64 Object.getPrototypeOf(prototype),
59 name); 65 name);
60 for (var i = 0; i < propNames.length; i++) { 66 for (var i = 0; i < propNames.length; i++) {
61 var propName = propNames[i]; 67 var propName = propNames[i];
62 if (propName == "constructor") continue; 68 if (propName == "constructor") continue;
69 if (isV8Native(name)) continue;
63 var testName = name + "-" + propName; 70 var testName = name + "-" + propName;
64 var propDesc = Object.getOwnPropertyDescriptor(prototype, propName); 71 var propDesc = Object.getOwnPropertyDescriptor(prototype, propName);
65 assertTrue(propDesc.hasOwnProperty("value"), testName); 72 assertTrue(propDesc.hasOwnProperty("value"), testName);
66 assertFalse(propDesc.configurable, testName); 73 assertFalse(propDesc.configurable, testName);
67 if (isFunction(propDesc.value)) { 74 if (isFunction(propDesc.value)) {
68 assertFalse(propDesc.writable, testName); 75 assertFalse(propDesc.writable, testName);
69 } 76 }
70 } 77 }
71 } 78 }
72 79
73 for (var i = 0; i < names.length; i++) { 80 for (var i = 0; i < names.length; i++) {
74 var name = names[i]; 81 var name = names[i];
75 var desc = Object.getOwnPropertyDescriptor(builtins, name); 82 var desc = Object.getOwnPropertyDescriptor(builtins, name);
76 assertTrue(desc.hasOwnProperty("value")); 83 assertTrue(desc.hasOwnProperty("value"));
77 var value = desc.value; 84 var value = desc.value;
78 if (isFunction(value)) { 85 if (isFunction(value)) {
79 checkConstructor(value, name); 86 checkConstructor(value, name);
80 } 87 }
81 } 88 }
OLDNEW
« no previous file with comments | « test/cctest/test-ordered-hash-table.cc ('k') | test/mjsunit/debug-script.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698