Issue 427713005: Move functions from GrDrawState.h to GrDrawState.cpp and delete unused functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 427713005: Move functions from GrDrawState.h to GrDrawState.cpp and delete unused functions. (Closed)

Created:
6 years, 4 months ago by bsalomon

Modified:
6 years, 4 months ago

Reviewers:
egdaniel

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@colorcheck

Visibility:
Public.

More Reviews

Description

Move functions from GrDrawState.h to GrDrawState.cpp and delete unused functions. Committed: https://skia.googlesource.com/skia/+/8f7273399466c95c0c86b099de438d6ef1a15c88

Patch Set 2 : rebase #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -197 lines)			Patch
	M	src/gpu/GrDrawState.h	View	1	5 chunks	+8 lines, -197 lines	0 comments	Download
	M	src/gpu/GrDrawState.cpp	View		2 chunks	+152 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bsalomon

None of the moved code was changed. https://codereview.chromium.org/427713005/diff/1/src/gpu/GrDrawState.h File src/gpu/GrDrawState.h (left): https://codereview.chromium.org/427713005/diff/1/src/gpu/GrDrawState.h#oldcode172 src/gpu/GrDrawState.h:172: /** These ...

6 years, 4 months ago (2014-08-04 21:05:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/427713005/20001

6 years, 4 months ago (2014-08-05 14:38:55 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-05 14:50:14 UTC) #5

Message was sent while issue was closed.

Change committed as 8f7273399466c95c0c86b099de438d6ef1a15c88

Expand Messages | Collapse Messages

Issue 427713005: Move functions from GrDrawState.h to GrDrawState.cpp and delete unused functions. (Closed)

Description

Patch Set 1 #

Patch Set 2 : rebase #

Messages