Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: content/renderer/media/media_stream_impl.cc

Issue 427713004: Add histogram WebRTC.UserMediaRequest.Events to allow to track getUserMedia failures and hangs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_impl.cc
diff --git a/content/renderer/media/media_stream_impl.cc b/content/renderer/media/media_stream_impl.cc
index 887b593b9cf42eb91f91e2783d2b82532dcce765..0c891536fb7df508b8a365dcf83d1b9694cac127 100644
--- a/content/renderer/media/media_stream_impl.cc
+++ b/content/renderer/media/media_stream_impl.cc
@@ -180,6 +180,7 @@ void MediaStreamImpl::requestUserMedia(
video_device_id.c_str(),
mandatory_video ? "true":"false"));
+ LogUserMediaRequestEvent(USERMEDIAREQUEST_CREATED);
user_media_requests_.push_back(
new UserMediaRequestInfo(request_id, user_media_request,
enable_automatic_output_device_selection));
@@ -199,6 +200,7 @@ void MediaStreamImpl::cancelUserMediaRequest(
// We can't abort the stream generation process.
// Instead, erase the request. Once the stream is generated we will stop the
// stream if the request does not exist.
+ LogUserMediaRequestEvent(USERMEDIAREQUEST_CANCELLED);
DeleteUserMediaRequestInfo(request);
}
}
@@ -349,6 +351,7 @@ void MediaStreamImpl::OnStreamGenerationFailed(
}
GetUserMediaRequestFailed(&request_info->request, result);
+ LogUserMediaRequestResult(result);
DeleteUserMediaRequestInfo(request_info);
}
@@ -503,6 +506,7 @@ void MediaStreamImpl::OnCreateNativeTracksCompleted(
else
GetUserMediaRequestFailed(&request->request, result);
+ LogUserMediaRequestResult(result);
DeleteUserMediaRequestInfo(request);
}
@@ -758,6 +762,7 @@ void MediaStreamImpl::FrameWillClose() {
media_stream_dispatcher_->CancelGenerateStream(
(*request_it)->request_id, weak_factory_.GetWeakPtr());
}
+ LogUserMediaRequestEvent(USERMEDIAREQUEST_NO_RESPONSE);
vrk (LEFT CHROMIUM) 2014/08/04 18:22:17 There are a few different "no response" events tha
request_it = user_media_requests_.erase(request_it);
}
« no previous file with comments | « no previous file | content/renderer/media/webrtc_uma_histograms.h » ('j') | content/renderer/media/webrtc_uma_histograms.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698