Add histogram WebRTC.UserMediaRequest.Events to allow to track getUserMedia failures and hangs.

Add histogram WebRTC.UserMediaRequest.Result to track getUserMedia success and failure reasons.

BUG=399835
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287614

[vrk (LEFT CHROMIUM), 2014-08-04 18:22:17]

Thanks for wiring this up!

https://codereview.chromium.org/427713004/diff/1/content/renderer/media/media...
File content/renderer/media/media_stream_impl.cc (right):

https://codereview.chromium.org/427713004/diff/1/content/renderer/media/media...
content/renderer/media/media_stream_impl.cc:765:
LogUserMediaRequestEvent(USERMEDIAREQUEST_NO_RESPONSE);
There are a few different "no response" events that we want to be able to
distinguish:
- gUM is called, and the user never clicks allow/deny
- gUM is called, user clicks allow, and the success callback never returns
- gUM is called, user clicks deny, and the failure callback never returns

I think this would lump the above scenarios into one category. How hard would it
be to separate out these scenarios? If it's difficult, I'm fine with the current
behavior and we can discuss adding this distinction later.

https://codereview.chromium.org/427713004/diff/1/content/renderer/media/webrt...
File content/renderer/media/webrtc_uma_histograms.h (right):

https://codereview.chromium.org/427713004/diff/1/content/renderer/media/webrt...
content/renderer/media/webrtc_uma_histograms.h:18: USERMEDIAREQUEST_CREATED = 0,
I don't think CREATED is a useful histogram value - it will skew the other
percentages, since every CREATED gets counted for every CANCELLED and
NO_RESPONSE value.

I think it'd make more sense to split the values up as follows:
- gUM returned Success
- gUM returned Failure
- gUM cancelled
- gUM called but no response*

*As per other comment, would be better if we could drill down more specifically:
- gUM called, user allowed permission, and no response
- gUM called, user denied permission, and no response
- gUM called, user did not allow/deny permission

https://codereview.chromium.org/427713004/diff/1/content/renderer/media/webrt...
content/renderer/media/webrtc_uma_histograms.h:23: USERMEDIAREQUEST_RESULT = 10,
ISTM it'd make more sense to have two histograms:

UserMediaRequest.event: histogram of how often gUM returns with success or
failure vs cancel or no response
- UserMediaRequestEvent enum 

UserMediaRequest.result: histogram of results for the gUM calls that do return
either success or failure
- MediaStreamRequestResult enum

So then you wouldn't need to have the USERMEDIAREQUEST_RESULT = 10 stuff.

[andresp-chromium, 2014-08-04 19:16:24]

Keeping this CL simple and just logging UserMediaRequests results for now.

Will send another one for tracking UserMediaRequests hangs and cancellations.

https://codereview.chromium.org/427713004/diff/1/content/renderer/media/webrt...
File content/renderer/media/webrtc_uma_histograms.h (right):

https://codereview.chromium.org/427713004/diff/1/content/renderer/media/webrt...
content/renderer/media/webrtc_uma_histograms.h:18: USERMEDIAREQUEST_CREATED = 0,
This was intended to be an events counter.. in such case it would be acceptable
that events were unrelated and percentage diagrams wouldn't need to make sense
(IMO).

Anyhow when I started following all the code paths with stream generation and so
on it became harder so I am splitting this part into another CL (to prepare
tomorrow) and for now this CL only has stream request result being logged.

On 2014/08/04 18:22:17, Victoria Kirst wrote:
> I don't think CREATED is a useful histogram value - it will skew the other
> percentages, since every CREATED gets counted for every CANCELLED and
> NO_RESPONSE value.
> 
> I think it'd make more sense to split the values up as follows:
> - gUM returned Success
> - gUM returned Failure
> - gUM cancelled
> - gUM called but no response*
> 
> *As per other comment, would be better if we could drill down more
specifically:
> - gUM called, user allowed permission, and no response
> - gUM called, user denied permission, and no response
> - gUM called, user did not allow/deny permission

https://codereview.chromium.org/427713004/diff/1/content/renderer/media/webrt...
content/renderer/media/webrtc_uma_histograms.h:23: USERMEDIAREQUEST_RESULT = 10,
Totally agree.

On 2014/08/04 18:22:17, Victoria Kirst wrote:
> ISTM it'd make more sense to have two histograms:
> 
> UserMediaRequest.event: histogram of how often gUM returns with success or
> failure vs cancel or no response
> - UserMediaRequestEvent enum 
> 
> UserMediaRequest.result: histogram of results for the gUM calls that do return
> either success or failure
> - MediaStreamRequestResult enum
> 
> So then you wouldn't need to have the USERMEDIAREQUEST_RESULT = 10 stuff.

[Alexei Svitkine (slow), 2014-08-05 15:33:37]

lgtm

[vrk (LEFT CHROMIUM), 2014-08-05 18:31:44]

lgtm

[commit-bot: I haz the power, 2014-08-05 18:33:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/andresp@chromium.org/427713004/60001

[commit-bot: I haz the power, 2014-08-05 22:18:43]

Change committed as 287614