Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 427693004: IPC: Add more debug logic (crash tracking) (Closed)

Created:
6 years, 4 months ago by rvargas (doing something else)
Modified:
6 years, 4 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

IPC: Add more debug logic (crash tracking) BUG=387876 R=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286759

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M ipc/ipc_channel_win.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ipc/ipc_channel_win.cc View 4 chunks +9 lines, -2 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
rvargas (doing something else)
6 years, 4 months ago (2014-07-28 21:52:51 UTC) #1
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/427693004/diff/1/ipc/ipc_channel_win.cc File ipc/ipc_channel_win.cc (right): https://codereview.chromium.org/427693004/diff/1/ipc/ipc_channel_win.cc#newcode444 ipc/ipc_channel_win.cc:444: ERROR_IO_PENDING is the normal case, right? so writing_ will ...
6 years, 4 months ago (2014-07-29 19:47:20 UTC) #2
rvargas (doing something else)
https://codereview.chromium.org/427693004/diff/1/ipc/ipc_channel_win.cc File ipc/ipc_channel_win.cc (right): https://codereview.chromium.org/427693004/diff/1/ipc/ipc_channel_win.cc#newcode444 ipc/ipc_channel_win.cc:444: On 2014/07/29 19:47:20, cpu wrote: > ERROR_IO_PENDING is the ...
6 years, 4 months ago (2014-07-29 20:36:21 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
6 years, 4 months ago (2014-07-30 22:43:41 UTC) #4
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 4 months ago (2014-07-31 00:17:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/427693004/1
6 years, 4 months ago (2014-07-31 00:23:13 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 12:24:36 UTC) #7
Message was sent while issue was closed.
Change committed as 286759

Powered by Google App Engine
This is Rietveld 408576698