Source/core/css/parser/SizesAttributeParserTest.cpp - Issue 427683002: Bug fix - rem & ch in MQs/sizes treated as unknown units

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/SizesAttributeParserTest.cpp

Issue 427683002: Bug fix - rem & ch in MQs/sizes treated as unknown units (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix ch as well Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/parser/SizesAttributeParserTest.cpp

diff --git a/Source/core/css/parser/SizesAttributeParserTest.cpp b/Source/core/css/parser/SizesAttributeParserTest.cpp

index 6af36fb8204cdcd45a0461feba70bad6d0d9635d..09352e62a3bd391ec87abed56d5575c819f7a05b 100644

--- a/Source/core/css/parser/SizesAttributeParserTest.cpp

+++ b/Source/core/css/parser/SizesAttributeParserTest.cpp

@@ -46,6 +46,8 @@ TEST(SizesAttributeParserTest, Basic)

{"(max-width: 3000px) 200w, 400w", 500},

{",, , /**/ ,200px", 200},

{"50vw", 250},

+ {"5em", 80},

+ {"5rem", 80},

{"calc(40vw*2)", 400},

{"(min-width:5000px) calc(5000px/10), (min-width:500px) calc(1200px/3)", 400},

{"(min-width:500px) calc(1200/3)", 500},

« Source/core/css/MediaQueryExp.cpp ('K') | « Source/core/css/MediaQuerySetTest.cpp ('k') | no next file » | no next file with comments »