Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: Source/core/frame/Frame.cpp

Issue 427673008: Move FrameDestructionObserver into LocalFrame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/Frame.h ('k') | Source/core/frame/LocalFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/Frame.cpp
diff --git a/Source/core/frame/Frame.cpp b/Source/core/frame/Frame.cpp
index f3b756c49ab99af3821ed84e453db9e427d38231..4b4894a999c34a8a5722a6e8ba17a18391c5a651 100644
--- a/Source/core/frame/Frame.cpp
+++ b/Source/core/frame/Frame.cpp
@@ -33,7 +33,6 @@
#include "core/dom/DocumentType.h"
#include "core/events/Event.h"
#include "core/frame/LocalDOMWindow.h"
-#include "core/frame/FrameDestructionObserver.h"
#include "core/frame/FrameHost.h"
#include "core/frame/Settings.h"
#include "core/html/HTMLFrameElementBase.h"
@@ -90,20 +89,6 @@ Frame::~Frame()
#ifndef NDEBUG
frameCounter.decrement();
#endif
-
- HashSet<FrameDestructionObserver*>::iterator stop = m_destructionObservers.end();
- for (HashSet<FrameDestructionObserver*>::iterator it = m_destructionObservers.begin(); it != stop; ++it)
- (*it)->frameDestroyed();
-}
-
-void Frame::addDestructionObserver(FrameDestructionObserver* observer)
-{
- m_destructionObservers.add(observer);
-}
-
-void Frame::removeDestructionObserver(FrameDestructionObserver* observer)
-{
- m_destructionObservers.remove(observer);
}
FrameHost* Frame::host() const
@@ -175,24 +160,6 @@ void Frame::setRemotePlatformLayer(blink::WebLayer* layer)
renderer->layer()->updateSelfPaintingLayer();
}
-void Frame::willDetachFrameHost()
-{
- HashSet<FrameDestructionObserver*>::iterator stop = m_destructionObservers.end();
- for (HashSet<FrameDestructionObserver*>::iterator it = m_destructionObservers.begin(); it != stop; ++it)
- (*it)->willDetachFrameHost();
-
- // FIXME: Page should take care of updating focus/scrolling instead of Frame.
- // FIXME: It's unclear as to why this is called more than once, but it is,
- // so page() could be null.
- if (page() && page()->focusController().focusedFrame() == this)
- page()->focusController().setFocusedFrame(nullptr);
-}
-
-void Frame::detachFromFrameHost()
-{
- m_host = 0;
-}
-
bool Frame::isMainFrame() const
{
Page* page = this->page();
« no previous file with comments | « Source/core/frame/Frame.h ('k') | Source/core/frame/LocalFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698