disable WebView SSL exception when command line flag ignore-certificate-errors is given

android_webview/native/aw_contents_client_bridge.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/native/aw_contents_client_bridge.h"
 
 #include "android_webview/common/devtools_instrumentation.h"
 #include "android_webview/native/aw_contents.h"
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/callback_helpers.h"
+#include "base/command_line.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/common/content_switches.h"
 #include "crypto/scoped_openssl_types.h"
 #include "jni/AwContentsClientBridge_jni.h"
 #include "net/android/keystore_openssl.h"
 #include "net/cert/x509_certificate.h"
 #include "net/ssl/openssl_client_key_store.h"
 #include "net/ssl/ssl_cert_request_info.h"
 #include "net/ssl/ssl_client_cert_type.h"
 #include "url/gurl.h"
 
 using base::android::AttachCurrentThread;
@@ skipping 72 matching lines @@
   }
 }
 
 void AwContentsClientBridge::ProceedSslError(JNIEnv* env, jobject obj,
                                              jboolean proceed, jint id) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   CertErrorCallback* callback = pending_cert_error_callbacks_.Lookup(id);
   if (!callback || callback->is_null()) {
     LOG(WARNING) << "Ignoring unexpected ssl error proceed callback";
     return;
+  } else if (CommandLine::ForCurrentProcess()->HasSwitch(

[mnaganov (inactive), 2014/07/29 08:24:48]

It looks like you'll end up with error callbacks piling up in the map because
you are not removing them. How about this flow:

if (!callback ...) {
  ...
}
if (!HasSwitch(...)) {
  callback->Run(proceed);
} else {
  LOG ...
}
pending_cert_error_callbacks_.Remove(id);

+        switches::kIgnoreCertificateErrors)) {
+    LOG(WARNING) << "Ignoring unexpected ssl error due to command line flag";
+    return;
   }
   callback->Run(proceed);
   pending_cert_error_callbacks_.Remove(id);
 }
 
 // This method is inspired by SelectClientCertificate() in
 // chrome/browser/ui/android/ssl_client_certificate_request.cc
 void AwContentsClientBridge::SelectClientCertificate(
       net::SSLCertRequestInfo* cert_request_info,
       const SelectCertificateCallback& callback) {
@@ skipping 258 matching lines @@
       pending_client_cert_request_callbacks_.Lookup(request_id);
   callback->Run(scoped_refptr<net::X509Certificate>());
   pending_client_cert_request_callbacks_.Remove(request_id);
 }
 
 bool RegisterAwContentsClientBridge(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android_webview