Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: Source/core/animation/AnimationNode.h

Issue 427673004: Oilpan: Move AnimationNode::EventDelegate to oilpan's heap (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/Animation.cpp ('k') | Source/core/animation/AnimationNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/AnimationNode.h
diff --git a/Source/core/animation/AnimationNode.h b/Source/core/animation/AnimationNode.h
index 4de7c26819d07cf4ed661193f5739efff8023d45..1348094eb757148fc8d9928f43cf1a6da7c2f14b 100644
--- a/Source/core/animation/AnimationNode.h
+++ b/Source/core/animation/AnimationNode.h
@@ -70,10 +70,11 @@ public:
PhaseNone,
};
- class EventDelegate {
+ class EventDelegate : public NoBaseWillBeGarbageCollectedFinalized<EventDelegate> {
public:
- virtual ~EventDelegate() { };
+ virtual ~EventDelegate() { }
virtual void onEventCondition(const AnimationNode*) = 0;
+ virtual void trace(Visitor*) { }
};
virtual ~AnimationNode() { }
@@ -114,7 +115,7 @@ public:
virtual void trace(Visitor*);
protected:
- explicit AnimationNode(const Timing&, PassOwnPtr<EventDelegate> = nullptr);
+ explicit AnimationNode(const Timing&, PassOwnPtrWillBeRawPtr<EventDelegate> = nullptr);
// When AnimationNode receives a new inherited time via updateInheritedTime
// it will (if necessary) recalculate timings and (if necessary) call
@@ -147,7 +148,7 @@ protected:
const double m_startTime;
RawPtrWillBeMember<AnimationPlayer> m_player;
Timing m_timing;
- OwnPtr<EventDelegate> m_eventDelegate;
+ OwnPtrWillBeMember<EventDelegate> m_eventDelegate;
mutable struct CalculatedTiming {
Phase phase;
« no previous file with comments | « Source/core/animation/Animation.cpp ('k') | Source/core/animation/AnimationNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698