Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: pkg/polymer/lib/transformer.dart

Issue 427623002: Polymer transformer logs now show on the frontend for pub serve. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: added option to enable the element (opt in now) and cleanup Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/polymer/lib/transformer.dart
diff --git a/pkg/polymer/lib/transformer.dart b/pkg/polymer/lib/transformer.dart
index cbba25777fc624b20eb93e7df9dcef52afa6bc1f..35d8b75632f7b07a47236210d3f938721fd1b24d 100644
--- a/pkg/polymer/lib/transformer.dart
+++ b/pkg/polymer/lib/transformer.dart
@@ -13,6 +13,7 @@ import 'src/build/build_filter.dart';
import 'src/build/common.dart';
import 'src/build/import_inliner.dart';
import 'src/build/linter.dart';
+import 'src/build/build_log_combiner.dart';
import 'src/build/polyfill_injector.dart';
import 'src/build/script_compactor.dart';
@@ -41,13 +42,16 @@ TransformOptions _parseSettings(BarbackSettings settings) {
bool jsOption = args['js'];
bool csp = args['csp'] == true; // defaults to false
bool lint = args['lint'] != false; // defaults to true
+ bool injectBuildLogs =
+ !releaseMode && args['inject_build_logs_in_output'] == true;
Siggi Cherem (dart-lang) 2014/08/04 22:30:26 let's make it true by default: !releaseMode && ar
jakemac 2014/08/05 18:33:31 Done.
return new TransformOptions(
entryPoints: _readEntrypoints(args['entry_points']),
inlineStylesheets: _readInlineStylesheets(args['inline_stylesheets']),
directlyIncludeJS: jsOption == null ? releaseMode : jsOption,
contentSecurityPolicy: csp,
releaseMode: releaseMode,
- lint: lint);
+ lint: lint,
+ injectBuildLogsInOutput: injectBuildLogs);
}
_readEntrypoints(value) {
@@ -119,8 +123,9 @@ List<List<Transformer>> createDeployPhases(
[new ObservableTransformer()],
[new ScriptCompactor(options, sdkDir: sdkDir)],
[new PolyfillInjector(options)],
- [new BuildFilter(options)]
+ [new BuildFilter(options)],
+ [new BuildLogCombiner(options)],
]);
}
-final RegExp _PACKAGE_PATH_REGEX = new RegExp(r'packages\/([^\/]+)\/(.*)');
+final RegExp _PACKAGE_PATH_REGEX = new RegExp(r'packages\/([^\/]+)\/(.*)');

Powered by Google App Engine
This is Rietveld 408576698