Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: pkg/polymer/lib/src/build/log_injector.dart

Issue 427623002: Polymer transformer logs now show on the frontend for pub serve. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review updates Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/polymer/lib/src/build/log_injector.dart
diff --git a/pkg/polymer/lib/src/build/log_injector.dart b/pkg/polymer/lib/src/build/log_injector.dart
new file mode 100644
index 0000000000000000000000000000000000000000..66cdfb317bf6a787788ee1f05c5fe6dcbbe9c43d
--- /dev/null
+++ b/pkg/polymer/lib/src/build/log_injector.dart
@@ -0,0 +1,111 @@
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+/// This library provides a single function called injectLogs which when called
+/// will request a logs json file and build a small widget out of them which
+/// groups the logs by level.
+library polymer.build.log_injector;
+
+import 'dart:convert';
+import 'dart:html';
+
+import 'package:path/path.dart' as path;
+
+class LogInjector {
+ Element selectedMenu;
+ Element selectedContent;
+
+ LogInjector created();
Siggi Cherem (dart-lang) 2014/08/04 20:38:37 delete?
jakemac 2014/08/04 22:21:57 Done.
+
+ // Gets the logs and builds the html for the logs element, and injects that into
Siggi Cherem (dart-lang) 2014/08/04 20:38:37 nit: 80 colums
jakemac 2014/08/04 22:21:58 Done.
+ // the dom. Currently, we do not use Polymer just to ensure that the page works
+ // regardless of the state of the app. Ideally, we could have multiple scripts
+ // running independently so we could ensure that this would always be running.
+ injectLogs() {
+ var buildLogsUrl = '${window.location.href}._buildLogs';
+ var r = HttpRequest.getString(buildLogsUrl).then((data) {
+ // Group all logs by level.
+ var logsByLevel = {
+ };
+ JSON.decode(data).forEach((log) {
+ logsByLevel.putIfAbsent(log['level'], () => []);
+ logsByLevel[log['level']].add(log);
+ });
+ if (logsByLevel.isEmpty) return;
+
+ // Build the wrapper, menu, and content divs.
+ var wrapperDiv = new DivElement()
Siggi Cherem (dart-lang) 2014/08/04 20:38:37 nit: we could move this wrapper down, and have the
jakemac 2014/08/04 22:21:58 Done.
+ ..classes.add('build-logs');
+ var menuWrapper = new DivElement()
+ ..classes.add('menu');
+ var contentWrapper = new DivElement()
+ ..classes.add('content');
+ wrapperDiv
+ ..append(menuWrapper)
+ ..append(contentWrapper);
+
+ // For each log level, add a menu item, content section, and all the logs.
+ logsByLevel.forEach((level, logs) {
+ var levelClassName = level.toLowerCase();
+
+ // Add the menu item and content item.
+ var menuItem = new Element.html(
+ '<div class="$levelClassName">'
+ '$level <span class="num">(${logs.length})</span>'
+ '</div>');
+ menuWrapper.append(menuItem);
+ var contentItem = new DivElement()
+ ..classes.add(levelClassName);
+ contentWrapper.append(contentItem);
+
+ // Set up the click handlers.
+ menuItem.onClick.listen((_) {
+ if (selectedMenu == menuItem) {
+ selectedMenu = null;
+ selectedContent = null;
+ } else {
+ if (selectedMenu != null) {
+ selectedMenu.classes.remove('active');
+ selectedContent.classes.remove('active');
+ }
+
+ selectedMenu = menuItem;
+ selectedContent = contentItem;
+ }
+
+ menuItem.classes.toggle('active');
+ contentItem.classes.toggle('active');
+ });
+
+ // Add the logs to the content item.
+ for (var log in logs) {
+ var logHtml = new StringBuffer();
+ logHtml.write('<div class="log">');
+ logHtml.write(
+ '<div class="message $levelClassName">${log['message']}</div>');
+ var assetId = log['assetId'];
+ if (assetId != null) {
+ logHtml.write(
+ '<div class="asset">'
+ ' <span class="package">${assetId['package']}</span>:'
+ ' <span class="path">${assetId['path']}</span>''</div>');
+ }
+ var span = log['span'];
+ if (span != null) {
+ logHtml.write(
+ '<div class="span">'
+ ' <div class="location">${span['location']}</div>'
+ ' <code class="text">${span['text']}</code>''</div>');
+ }
+ logHtml.write('</div>');
+
+ contentItem.append(new Element.html(logHtml.toString()));
+ };
+ });
+
+ document.body.append(wrapperDiv);
+ });
+ }
+
+}

Powered by Google App Engine
This is Rietveld 408576698