Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2426)

Unified Diff: pkg/polymer/lib/src/build/common.dart

Issue 427623002: Polymer transformer logs now show on the frontend for pub serve. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: dont wrap the logger in release mode Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/polymer/lib/src/build/common.dart
diff --git a/pkg/polymer/lib/src/build/common.dart b/pkg/polymer/lib/src/build/common.dart
index 89ea9b6bdbf1263692b42fe918d292de167f38c7..fd62d57aa0ba829619e1a38919a189e6bf7331de 100644
--- a/pkg/polymer/lib/src/build/common.dart
+++ b/pkg/polymer/lib/src/build/common.dart
@@ -77,6 +77,10 @@ class TransformOptions {
/// minified versions of the polyfills rather than the debug versions.
final bool releaseMode;
+ /// This will make a physical element appear on the page showing build logs.
+ /// It will only appear when ![releaseMode] even if this is true.
+ final bool injectBuildLogsInOutput;
+
/// True to run liner on all html files before starting other phases.
// TODO(jmesserly): instead of this flag, we should only run linter on
// reachable (entry point+imported) html if deploying. See dartbug.com/17199.
@@ -84,7 +88,8 @@ class TransformOptions {
TransformOptions({entryPoints, this.inlineStylesheets,
this.contentSecurityPolicy: false, this.directlyIncludeJS: true,
- this.releaseMode: true, this.lint: true})
+ this.releaseMode: true, this.lint: true,
+ this.injectBuildLogsInOutput: false})
: entryPoints = entryPoints == null ? null
: entryPoints.map(systemToAssetPath).toList();
@@ -230,3 +235,5 @@ bool isCustomTagName(String name) {
final ATTRIBUTES_REGEX = new RegExp(r'\s|,');
const POLYMER_EXPERIMENTAL_HTML = 'packages/polymer/polymer_experimental.html';
+
+const String LOG_EXTENSION = '._buildLogs';

Powered by Google App Engine
This is Rietveld 408576698