pkg/polymer/lib/src/build/common.dart - Issue 427623002: Polymer transformer logs now show on the frontend for pub serve.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pkg/polymer/lib/src/build/common.dart

Issue 427623002: Polymer transformer logs now show on the frontend for pub serve. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: code review updates Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« pkg/polymer/lib/src/build/build_log_combiner.dart ('K') | « pkg/polymer/lib/src/build/build_log_combiner.dart ('k') | pkg/polymer/lib/src/build/import_inliner.dart » ('j') | pkg/polymer/lib/src/build/log_injector.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 /// Common methods used by transfomers.	5 /// Common methods used by transfomers.

6 library polymer.src.build.common;	6 library polymer.src.build.common;

7	7

8 import 'dart:async';	8 import 'dart:async';

9	9

10 import 'package:analyzer/src/generated/ast.dart';	10 import 'package:analyzer/src/generated/ast.dart';

(...skipping 188 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
199 bool isCustomTagName(String name) {	199 bool isCustomTagName(String name) {

200 if (name == null \|\| !name.contains('-')) return false;	200 if (name == null \|\| !name.contains('-')) return false;

201 return !invalidTagNames.containsKey(name);	201 return !invalidTagNames.containsKey(name);

202 }	202 }

203	203

204 /// Regex to split names in the 'attributes' attribute, which supports 'a b c',	204 /// Regex to split names in the 'attributes' attribute, which supports 'a b c',

205 /// 'a,b,c', or even 'a b,c'. This is the same as in `lib/src/declaration.dart`.	205 /// 'a,b,c', or even 'a b,c'. This is the same as in `lib/src/declaration.dart`.

206 final ATTRIBUTES_REGEX = new RegExp(r'\s\|,');	206 final ATTRIBUTES_REGEX = new RegExp(r'\s\|,');

207	207

208 const POLYMER_EXPERIMENTAL_HTML = 'packages/polymer/polymer_experimental.html';	208 const POLYMER_EXPERIMENTAL_HTML = 'packages/polymer/polymer_experimental.html';

	209

	210 const String LOG_EXTENSION = '._buildLogs';

OLD	NEW