Polymer transformer logs now show on the frontend for pub serve.

pkg/polymer/lib/src/build/add_log_injector.dart

+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+/// Logic to add the log_injector script.
+library polymer.src.build.add_log_injector;
+
+import 'dart:async';
+
+import 'package:barback/barback.dart';
+
+import 'common.dart';
+
+/// Simply injects the script and stylesheet for the log_injector for entry
+/// points when not in release mode.
+class AddLogInjector extends Transformer with PolymerTransformer {
+
+  final TransformOptions options;
+
+  AddLogInjector(this.options);
+
+

[Siggi Cherem (dart-lang), 2014/08/01 21:31:51]

nit: remove empty line

[jakemac, 2014/08/04 19:49:58]

Done.

+  // Run only on entry point html files in !releaseMode.
+  Future<bool> isPrimary(idOrAsset) {

[Siggi Cherem (dart-lang), 2014/08/01 21:31:51]

let's remove the type (since we return bool or Future<bool> below), or make it
bool and return synchronously in line 27 too?

[jakemac, 2014/08/04 19:49:58]

Done, good call.

+    if (options.releaseMode) return false;
+    var id = idOrAsset is AssetId ? idOrAsset : idOrAsset.id;
+    return new Future.value(options.isHtmlEntryPoint(id));
+  }
+
+  Future apply(Transform transform) {
+    return readPrimaryAsHtml(transform).then((document) {
+      document.body.innerHtml = '''
+<script type="application/dart"
+        src="packages/polymer/src/build/log_injector.dart"></script>

[Siggi Cherem (dart-lang), 2014/08/01 21:31:51]

this line is not necessary since this file is imported explicitly in the
_bootstrap.dart file that you generate in script_compactor.

I'm not sure, but this could bring us some trouble today because we have the
rule that there should be only 1 script tag per page. If you have an entrypoint
that contains a script tag, this might fail or produce an extra warning later
on?

[jakemac, 2014/08/04 19:49:57]

Removed it here, previously it was working because I was doing this before
inlining.

+<link rel="stylesheet" type="text/css"
+      href="packages/polymer/src/build/log_injector.css">

[Siggi Cherem (dart-lang), 2014/08/01 21:31:51]

since this is the only thing left to add on this phase, I'm thinking it might be
fine to add this also in script compactor and get rid of this extra phase
entirely.

[jakemac, 2014/08/04 19:49:57]

Added it to the log_combiner phase since that one is more related to this.

[Siggi Cherem (dart-lang), 2014/08/04 20:38:37]

makes sense, this might be premature optimization but - since script compactor
is already doing the other changes to include the .dart code for this, I think
it's fine to also add the .css there and save ourselves one more iteration of
parsing and reemiting the HTML file.

+${document.body.innerHtml}''';

[Siggi Cherem (dart-lang), 2014/08/01 21:31:51]

let's use append, that way we don't serialize and deserialize the html twice.

[jakemac, 2014/08/04 19:49:57]

Done.

+
+      var output =
+          new Asset.fromString(transform.primaryInput.id, document.outerHtml);
+      transform.addOutput(output);
+    });
+  }
+
+}