Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1790)

Unified Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 427613006: Add SVGTests attrs to SVGSMILElement to support SVGDiscardElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/animation/SVGSMILElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/animation/SVGSMILElement.cpp
diff --git a/Source/core/svg/animation/SVGSMILElement.cpp b/Source/core/svg/animation/SVGSMILElement.cpp
index 903b246481fc94a26cfe1086e3ce0d76039b337b..c864e613caa6aa5d4b6d8f9e973e032047ce5816 100644
--- a/Source/core/svg/animation/SVGSMILElement.cpp
+++ b/Source/core/svg/animation/SVGSMILElement.cpp
@@ -170,6 +170,7 @@ SVGSMILElement::Condition::Condition(Type type, BeginOrEnd beginOrEnd, const Str
SVGSMILElement::SVGSMILElement(const QualifiedName& tagName, Document& doc)
: SVGElement(tagName, doc)
+ , SVGTests(this)
, m_attributeName(anyQName())
, m_targetElement(nullptr)
, m_syncBaseConditionsConnected(false)
@@ -505,6 +506,7 @@ bool SVGSMILElement::isSupportedAttribute(const QualifiedName& attrName)
{
DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
if (supportedAttributes.isEmpty()) {
+ SVGTests::addSupportedAttributes(supportedAttributes);
supportedAttributes.add(SVGNames::beginAttr);
supportedAttributes.add(SVGNames::endAttr);
supportedAttributes.add(SVGNames::durAttr);
@@ -542,8 +544,9 @@ void SVGSMILElement::parseAttribute(const QualifiedName& name, const AtomicStrin
setAttributeEventListener(EventTypeNames::endEvent, createAttributeEventListener(this, name, value, eventParameterName()));
} else if (name == SVGNames::onrepeatAttr) {
setAttributeEventListener(EventTypeNames::repeatEvent, createAttributeEventListener(this, name, value, eventParameterName()));
- } else
- SVGElement::parseAttribute(name, value);
+ } else {
+ SVGElement::parseAttributeNew(name, value);
+ }
}
void SVGSMILElement::svgAttributeChanged(const QualifiedName& attrName)
« no previous file with comments | « Source/core/svg/animation/SVGSMILElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698