Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 427613006: Add SVGTests attrs to SVGSMILElement to support SVGDiscardElement (Closed)

Created:
6 years, 4 months ago by kouhei (in TOK)
Modified:
6 years, 4 months ago
Reviewers:
haraken, pdr., fs
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, pdr., Eric Willigers
Project:
blink
Visibility:
Public.

Description

Add SVGTests attrs to SVGSMILElement to support SVGDiscardElement Before this CL, SVGAnimationElement derived SVGTests. However, given that SVGDiscardElement, which also derives SVGSMILElement need SVGTests support too, this CL changes SVGTests to be inherited in SVGSMILElement. Before: class SVGSMILElement {} class SVGAnimationElement : SVGSMILElement, SVGTests {} class SVGDiscardElement : SVGSMILElement {} After: class SVGSMILElement : SVGTests {} class SVGAnimationElement : SVGSMILElement {} class SVGDiscardElement : SVGSMILElement {} BUG=397991 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M Source/core/svg/SVGAnimationElement.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.cpp View 3 chunks +0 lines, -5 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kouhei (in TOK)
Would you take a look? fs: This modifies the hierarchy as we discussed in https://codereview.chromium.org/424733002/
6 years, 4 months ago (2014-07-29 03:45:32 UTC) #1
fs
LGTM
6 years, 4 months ago (2014-07-29 08:22:50 UTC) #2
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 4 months ago (2014-07-29 08:23:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/427613006/1
6 years, 4 months ago (2014-07-29 08:24:44 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 08:38:22 UTC) #5
Message was sent while issue was closed.
Change committed as 179107

Powered by Google App Engine
This is Rietveld 408576698