Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Side by Side Diff: pdf/pdfium/pdfium_engine.h

Issue 427583003: Fix UAF in chrome_pdf::Instance::GetURL() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Alternative, more correct fix (but riskier). Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PDF_PDFIUM_PDFIUM_ENGINE_H_ 5 #ifndef PDF_PDFIUM_PDFIUM_ENGINE_H_
6 #define PDF_PDFIUM_PDFIUM_ENGINE_H_ 6 #define PDF_PDFIUM_PDFIUM_ENGINE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 26 matching lines...) Expand all
37 class PDFiumEngine : public PDFEngine, 37 class PDFiumEngine : public PDFEngine,
38 public DocumentLoader::Client, 38 public DocumentLoader::Client,
39 public FPDF_FORMFILLINFO, 39 public FPDF_FORMFILLINFO,
40 public IPDF_JSPLATFORM, 40 public IPDF_JSPLATFORM,
41 public IFSDK_PAUSE { 41 public IFSDK_PAUSE {
42 public: 42 public:
43 explicit PDFiumEngine(PDFEngine::Client* client); 43 explicit PDFiumEngine(PDFEngine::Client* client);
44 virtual ~PDFiumEngine(); 44 virtual ~PDFiumEngine();
45 45
46 // PDFEngine implementation. 46 // PDFEngine implementation.
47 virtual void ClientDestroyed();
47 virtual bool New(const char* url); 48 virtual bool New(const char* url);
48 virtual bool New(const char* url, 49 virtual bool New(const char* url,
49 const char* headers); 50 const char* headers);
50 virtual void PageOffsetUpdated(const pp::Point& page_offset); 51 virtual void PageOffsetUpdated(const pp::Point& page_offset);
51 virtual void PluginSizeUpdated(const pp::Size& size); 52 virtual void PluginSizeUpdated(const pp::Size& size);
52 virtual void ScrolledToXPosition(int position); 53 virtual void ScrolledToXPosition(int position);
53 virtual void ScrolledToYPosition(int position); 54 virtual void ScrolledToYPosition(int position);
54 virtual void PrePaint(); 55 virtual void PrePaint();
55 virtual void Paint(const pp::Rect& rect, 56 virtual void Paint(const pp::Rect& rect,
56 pp::ImageData* image_data, 57 pp::ImageData* image_data,
(...skipping 560 matching lines...) Expand 10 before | Expand all | Expand 10 after
617 618
618 // See the definition of GetPDFPageSizeByIndex in pdf.cc for details. 619 // See the definition of GetPDFPageSizeByIndex in pdf.cc for details.
619 virtual bool GetPDFPageSizeByIndex(const void* pdf_buffer, 620 virtual bool GetPDFPageSizeByIndex(const void* pdf_buffer,
620 int pdf_buffer_size, int page_number, 621 int pdf_buffer_size, int page_number,
621 double* width, double* height); 622 double* width, double* height);
622 }; 623 };
623 624
624 } // namespace chrome_pdf 625 } // namespace chrome_pdf
625 626
626 #endif // PDF_PDFIUM_PDFIUM_ENGINE_H_ 627 #endif // PDF_PDFIUM_PDFIUM_ENGINE_H_
OLDNEW
« pdf/instance.cc ('K') | « pdf/pdf_engine.h ('k') | pdf/pdfium/pdfium_engine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698