Issue 427573002: Move scoped_observer.h from base_unittests to base. It is not a test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 427573002: Move scoped_observer.h from base_unittests to base. It is not a test. (Closed)

Created:
6 years, 4 months ago by jbroman

Modified:
6 years, 4 months ago

Reviewers:
brettw

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Move scoped_observer.h from base_unittests to base. It is not a test. Found with 'gn check'. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285985

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -2 lines)			Patch
M	base/BUILD.gn	View	2 chunks	+1 line, -1 line	0 comments	Download
M	base/base.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/base.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

jbroman

Found this with 'gn check'. I'm not a //base expert, but I don't see why ...

6 years, 4 months ago (2014-07-28 20:55:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/427573002/1

6 years, 4 months ago (2014-07-28 20:59:33 UTC) #4

Message was sent while issue was closed.

Change committed as 285985