Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 427563002: Remove HTMLFrameElement.width/height (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
CC:
arv+blink, blink-reviews, blink-reviews-html_chromium.org, Inactive, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -107 lines) Patch
M LayoutTests/fast/frames/frame-deep-nested-resize.html View 1 2 chunks +10 lines, -9 lines 0 comments Download
M LayoutTests/fast/frames/frame-inherit-noresize-from-frameset-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/frame-js-url-clientWidth.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/frames/frame-js-url-clientWidth-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/frames/frame-programmatic-noresize-expected.txt View 1 1 chunk +11 lines, -11 lines 0 comments Download
M LayoutTests/fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/fast/frames/frameElement-widthheight.html View 1 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/fast/frames/frameElement-widthheight-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/frames/frames-with-frameborder-zero-can-be-resized.html View 1 2 chunks +4 lines, -3 lines 0 comments Download
M LayoutTests/fast/frames/resources/frame-programmatic-resize.js View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameElement.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFrameElementBase.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFrameElementBase.cpp View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
fix tests
6 years, 4 months ago (2014-07-28 15:01:00 UTC) #1
philipj_slow
PTAL
6 years, 4 months ago (2014-07-29 09:08:33 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-07-29 11:42:27 UTC) #3
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-07-29 11:44:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/427563002/20001
6 years, 4 months ago (2014-07-29 11:44:44 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 12:18:16 UTC) #6
Message was sent while issue was closed.
Change committed as 179130

Powered by Google App Engine
This is Rietveld 408576698