Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 427553002: Add license entry for v8/third_party/fdlibm to tools/licenses.py. (Closed)

Created:
6 years, 4 months ago by Yang
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add license entry for v8/third_party/fdlibm to tools/licenses.py. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/licenses.py View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Yang
This prepares for adding fdlibm as third_party library to V8. See https://codereview.chromium.org/411263004/
6 years, 4 months ago (2014-08-04 07:04:53 UTC) #1
jochen (gone - plz use gerrit)
+pawel fyi lgtm
6 years, 4 months ago (2014-08-04 07:10:13 UTC) #2
Paweł Hajdan Jr.
Do you have a review from open-source-third-party-reviews@google.com and security@chromium.org ? Please see http://www.chromium.org/developers/adding-3rd-party-libraries#TOC-Get-a-Review I'm especially ...
6 years, 4 months ago (2014-08-04 11:23:56 UTC) #3
Yang
On 2014/08/04 11:23:56, Paweł Hajdan Jr. wrote: > Do you have a review from mailto:open-source-third-party-reviews@google.com ...
6 years, 4 months ago (2014-08-04 11:28:06 UTC) #4
Yang
The CQ bit was checked by yangguo@chromium.org
6 years, 4 months ago (2014-08-05 05:54:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yangguo@chromium.org/427553002/1
6 years, 4 months ago (2014-08-05 05:55:30 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 09:07:13 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 09:31:13 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/2755)
6 years, 4 months ago (2014-08-05 09:31:14 UTC) #9
Yang
The CQ bit was checked by yangguo@chromium.org
6 years, 4 months ago (2014-08-05 09:33:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yangguo@chromium.org/427553002/1
6 years, 4 months ago (2014-08-05 09:34:26 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 13:07:14 UTC) #12
Message was sent while issue was closed.
Change committed as 287525

Powered by Google App Engine
This is Rietveld 408576698