Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 427533003: Remove HTMLPreElement.wrap IDL attribute (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
CC:
arv+blink, blink-reviews, blink-reviews-html_chromium.org, Inactive, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix tests #

Patch Set 3 : leave style alone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M LayoutTests/fast/dom/boolean-attribute-reflection-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/script-tests/boolean-attribute-reflection.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLPreElement.cpp View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/html/HTMLPreElement.idl View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
fix tests
6 years, 4 months ago (2014-07-28 14:35:30 UTC) #1
philipj_slow
leave style alone
6 years, 4 months ago (2014-07-28 22:31:45 UTC) #2
philipj_slow
PTAL
6 years, 4 months ago (2014-07-29 09:13:21 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-07-29 11:41:44 UTC) #4
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-07-29 11:44:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/427533003/40001
6 years, 4 months ago (2014-07-29 11:46:19 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 12:18:53 UTC) #7
Message was sent while issue was closed.
Change committed as 179131

Powered by Google App Engine
This is Rietveld 408576698