Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 427433003: Disable SharedMemoryTest.AnonymousExecutable on iOS. (Closed)

Created:
6 years, 4 months ago by lliabraa
Modified:
6 years, 4 months ago
Reviewers:
jschuh, Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org, rohitrao (ping after 24h)
Project:
chromium
Visibility:
Public.

Description

Disable SharedMemoryTest.AnonymousExecutable on iOS. This test is not applicable for iOS. BUG=399384 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287107

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment about why test is ifdef'd out #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M base/memory/shared_memory_unittest.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
lliabraa
6 years, 4 months ago (2014-07-31 18:54:03 UTC) #1
lliabraa
+thakis for OWNERS jschuh is on board (see comment in bug)
6 years, 4 months ago (2014-07-31 19:27:16 UTC) #2
Nico
lgtm https://chromiumcodereview.appspot.com/427433003/diff/1/base/memory/shared_memory_unittest.cc File base/memory/shared_memory_unittest.cc (right): https://chromiumcodereview.appspot.com/427433003/diff/1/base/memory/shared_memory_unittest.cc#newcode517 base/memory/shared_memory_unittest.cc:517: #if !defined(OS_IOS) Add a comment that explains why ...
6 years, 4 months ago (2014-07-31 20:11:12 UTC) #3
lliabraa
thanks for the review. https://chromiumcodereview.appspot.com/427433003/diff/1/base/memory/shared_memory_unittest.cc File base/memory/shared_memory_unittest.cc (right): https://chromiumcodereview.appspot.com/427433003/diff/1/base/memory/shared_memory_unittest.cc#newcode517 base/memory/shared_memory_unittest.cc:517: #if !defined(OS_IOS) On 2014/07/31 20:11:12, ...
6 years, 4 months ago (2014-07-31 20:26:14 UTC) #4
lliabraa
The CQ bit was checked by lliabraa@chromium.org
6 years, 4 months ago (2014-07-31 20:26:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/427433003/20001
6 years, 4 months ago (2014-07-31 20:28:31 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-01 01:29:27 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-01 14:53:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/2375)
6 years, 4 months ago (2014-08-01 14:53:49 UTC) #9
lliabraa
The CQ bit was checked by lliabraa@chromium.org
6 years, 4 months ago (2014-08-01 14:58:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/427433003/20001
6 years, 4 months ago (2014-08-01 15:01:13 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 22:36:16 UTC) #12
Message was sent while issue was closed. 
Change committed as 287107

Powered by Google App Engine
This is Rietveld 408576698