Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 427393005: Fix RenderWidgetHostViewMac::SchedulePaintInRect (Closed)

Created:
6 years, 4 months ago by enne (OOO)
Modified:
6 years, 4 months ago
Reviewers:
ccameron, jbauman, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, miu+watch_chromium.org, nona+watch_chromium.org, penghuang+watch_chromium.org, James Su, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix RenderWidgetHostViewMac::SchedulePaintInRect This function in Aura is intended to be used for layer damage (not window damage), so make the Mac version do the same. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287474

Patch Set 1 #

Patch Set 2 : Fix compile error #

Total comments: 2

Patch Set 3 : piman nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
enne (OOO)
What do y'all think about this? I was confused about what this function should do ...
6 years, 4 months ago (2014-08-01 21:13:17 UTC) #1
piman
https://codereview.chromium.org/427393005/diff/20001/content/browser/renderer_host/render_widget_host_view_mac.mm File content/browser/renderer_host/render_widget_host_view_mac.mm (right): https://codereview.chromium.org/427393005/diff/20001/content/browser/renderer_host/render_widget_host_view_mac.mm#newcode429 content/browser/renderer_host/render_widget_host_view_mac.mm:429: if (GetLayer()) nit: the layer has the same lifetime ...
6 years, 4 months ago (2014-08-01 21:19:56 UTC) #2
piman
lgtm
6 years, 4 months ago (2014-08-01 21:20:02 UTC) #3
enne (OOO)
https://codereview.chromium.org/427393005/diff/20001/content/browser/renderer_host/render_widget_host_view_mac.mm File content/browser/renderer_host/render_widget_host_view_mac.mm (right): https://codereview.chromium.org/427393005/diff/20001/content/browser/renderer_host/render_widget_host_view_mac.mm#newcode429 content/browser/renderer_host/render_widget_host_view_mac.mm:429: if (GetLayer()) On 2014/08/01 21:19:56, piman (slow to review) ...
6 years, 4 months ago (2014-08-04 21:31:25 UTC) #4
piman
lgtm
6 years, 4 months ago (2014-08-04 21:43:45 UTC) #5
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 4 months ago (2014-08-04 21:56:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/427393005/40001
6 years, 4 months ago (2014-08-04 21:58:01 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 07:32:20 UTC) #8
Message was sent while issue was closed. 
Change committed as 287474

Powered by Google App Engine
This is Rietveld 408576698