Issue 427353005: Allow the forwarder to recover if the device_forwarder crashes or hangs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 427353005: Allow the forwarder to recover if the device_forwarder crashes or hangs (Closed)

Created:
6 years, 4 months ago by tonyg

Modified:
6 years, 4 months ago

Reviewers:
jbudorick

CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Allow the forwarder to recover if the device_forwarder crashes or hangs I've noticed on the perf bots that if we get a host_forwarder error because it can't connect to the device, then all subsequent forwarder operations will fail. Example: http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus4%20Perf/builds/1163/steps/Sharded%20Perf%20Tests/logs/stdio This patch fixes that by killing the device forwarder (and ensuring it isn't initialized) so that it can be re-initialized on the next attempt. BUG=294878 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287105

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -17 lines)			Patch
	M	build/android/pylib/forwarder.py	View		6 chunks	+6 lines, -17 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/427353005/1

6 years, 4 months ago (2014-08-01 18:24:38 UTC) #4

Message was sent while issue was closed.

Change committed as 287105