Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 427353002: Revert of Add UseCounters for non-standard, internally unused reflected attributes (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
CC:
arv+blink, blink-reviews, blink-reviews-html_chromium.org, Inactive, dglazkov+blink, kenneth.christiansen
Project:
blink
Visibility:
Public.

Description

Revert of Add UseCounters for non-standard, internally unused reflected attributes (https://codereview.chromium.org/428893002/) Reason for revert: These IDL attributes are actually in the HTML spec: http://www.whatwg.org/specs/web-apps/current-work/#obsolete Original issue's description: > Add UseCounters for non-standard, internally unused reflected attributes > > http://whatwg.org/html#htmlhtmlelement > http://whatwg.org/html#htmlmetaelement > http://whatwg.org/html#htmlobjectelement > http://whatwg.org/html#htmltablecellelement > > None of these attributes are used internally, so the only way sites > can depend on them is via these bindings. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179140 TBR=jochen@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179256

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M Source/core/frame/UseCounter.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/HTMLHtmlElement.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMetaElement.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableCellElement.idl View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
philipj_slow
Created Revert of Add UseCounters for non-standard, internally unused reflected attributes
6 years, 4 months ago (2014-07-30 21:35:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/427353002/1
6 years, 4 months ago (2014-07-30 21:36:43 UTC) #2
philipj_slow
The CQ bit was unchecked by philipj@opera.com
6 years, 4 months ago (2014-07-30 21:36:51 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 21:37:04 UTC) #4
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-07-30 21:37:04 UTC) #5
philipj_slow
rebase
6 years, 4 months ago (2014-07-30 21:42:35 UTC) #6
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-07-30 21:42:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/427353002/140001
6 years, 4 months ago (2014-07-30 21:43:58 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 21:45:00 UTC) #9
Message was sent while issue was closed.
Change committed as 179256

Powered by Google App Engine
This is Rietveld 408576698