src/ports/SkFontConfigParser_android.h - Issue 427293003: Implement SkFontMgr_Android::onMatchFamilyStyleCharacter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontConfigParser_android.h

Issue 427293003: Implement SkFontMgr_Android::onMatchFamilyStyleCharacter. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Address comments, move mask to parser. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontConfigParser_android.h

diff --git a/src/ports/SkFontConfigParser_android.h b/src/ports/SkFontConfigParser_android.h

index 8119fd7558e396161b89c9ba970df541cb133222..f54ed0600a4e8f69c63685ee3f8734663714ccbc 100644

--- a/src/ports/SkFontConfigParser_android.h

+++ b/src/ports/SkFontConfigParser_android.h

@@ -45,7 +45,7 @@ namespace SkFontConfigParser {

* Parses all system font configuration files and returns the results in an

* array of FontFamily structures.

-void GetFontFamilies(SkTDArray<FontFamily*> &fontFamilies);

+void GetFontFamilies(SkTDArray<FontFamily*> &fontFamilies, uint32_t ignoredFallbackVariants = 0);

djsollen 2014/07/31 14:51:37 add a comment to the method documenting what this

bungeman-skia 2014/07/31 22:15:53 Removed.

/**

* Parses all test font configuration files and returns the results in an