Issue 427293002: Reland "components: Fix a couple of the TODO(GYP) todos."

Issue 427293002: Reland "components: Fix a couple of the TODO(GYP) todos." (Closed)

Created:
6 years, 4 months ago by tfarina

Modified:
6 years, 4 months ago

Reviewers:
brettw, scottmg

CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, SeRya, jochen (gone - plz use gerrit), brettw

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Reland "components: Fix a couple of the TODO(GYP) todos." It was originally committed at r286362 and reverted in r286467. BUG=None TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn R=scottmg@chromium.org,brettw@chromium.org TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288006

Patch Set 1 #

Patch Set 2 : REBASE #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -13 lines)			Patch
M	components/autofill/content/browser/BUILD.gn	View		2 chunks	+1 line, -1 line	0 comments	Download
M	components/autofill/core/browser/BUILD.gn	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	components/invalidation/BUILD.gn	View	1	3 chunks	+4 lines, -5 lines	0 comments	Download
M	components/policy/core/browser/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	components/search_engines/BUILD.gn	View		2 chunks	+1 line, -1 line	0 comments	Download
A +	third_party/fips181/BUILD.gn	View		1 chunk	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

tfarina

Balancing the GN load. Scott, could you review this to me? Thanks,

6 years, 4 months ago (2014-08-03 13:54:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/427293002/20001

6 years, 4 months ago (2014-08-07 02:31:05 UTC) #9

Message was sent while issue was closed.

Change committed as 288006

Expand Messages | Collapse Messages