Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: runtime/lib/mirrors.cc

Issue 42723003: Register synthesized mixin application classes in the library and reuse them (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/mirrors_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors.cc
===================================================================
--- runtime/lib/mirrors.cc (revision 29272)
+++ runtime/lib/mirrors.cc (working copy)
@@ -352,7 +352,7 @@
// We do not set the names of anonymous mixin applications because the mirrors
// use a different naming convention than the VM (lib.S with lib.M and S&M
// respectively).
- if (!cls.IsMixinApplication() || cls.is_mixin_typedef()) {
+ if (!cls.IsAnonymousMixinApplication()) {
args.SetAt(2, String::Handle(cls.Name()));
}
args.SetAt(3, is_generic);
@@ -1211,7 +1211,8 @@
// We filter out function signature classes and dynamic.
// TODO(12478): Should not need to filter out dynamic.
if (!klass.IsCanonicalSignatureClass() &&
- !klass.IsDynamicClass()) {
+ !klass.IsDynamicClass() &&
+ !klass.IsAnonymousMixinApplication()) {
type = klass.DeclarationType();
member_mirror = CreateClassMirror(klass,
type,
« no previous file with comments | « no previous file | runtime/lib/mirrors_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698