Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 427153002: Add unsigned 64-bit integer support to BigEndianReader and BigEndianWriter. (Closed)

Created:
6 years, 4 months ago by Ben Chan
Modified:
6 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org, mikhal1, pwestin(chromium)
Project:
chromium
Visibility:
Public.

Description

Add unsigned 64-bit integer support to BigEndianReader and BigEndianWriter. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286636

Patch Set 1 : Fixed unit tests #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M base/big_endian.h View 2 chunks +2 lines, -0 lines 0 comments Download
M base/big_endian.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M base/big_endian_unittest.cc View 1 5 chunks +22 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ben Chan
6 years, 4 months ago (2014-07-30 06:04:44 UTC) #1
Mark Mentovai
LGTM otherwise. https://codereview.chromium.org/427153002/diff/20001/base/big_endian_unittest.cc File base/big_endian_unittest.cc (right): https://codereview.chromium.org/427153002/diff/20001/base/big_endian_unittest.cc#newcode84 base/big_endian_unittest.cc:84: EXPECT_TRUE(writer.WriteU64(0x0B0C0D0E0F1A2B3Clu)); This should be UINT64_C or llu, ...
6 years, 4 months ago (2014-07-30 13:18:05 UTC) #2
Ben Chan
https://codereview.chromium.org/427153002/diff/20001/base/big_endian_unittest.cc File base/big_endian_unittest.cc (right): https://codereview.chromium.org/427153002/diff/20001/base/big_endian_unittest.cc#newcode84 base/big_endian_unittest.cc:84: EXPECT_TRUE(writer.WriteU64(0x0B0C0D0E0F1A2B3Clu)); On 2014/07/30 13:18:05, Mark Mentovai wrote: > This ...
6 years, 4 months ago (2014-07-30 14:30:39 UTC) #3
Ben Chan
The CQ bit was checked by benchan@chromium.org
6 years, 4 months ago (2014-07-30 14:30:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benchan@chromium.org/427153002/40001
6 years, 4 months ago (2014-07-30 14:32:02 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-07-30 19:37:10 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 23:24:54 UTC) #7
Message was sent while issue was closed.
Change committed as 286636

Powered by Google App Engine
This is Rietveld 408576698