Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: content/shell/browser/shell_devtools_frontend.h

Issue 427143003: [DevTools] Move DevToolsClientHost functionality out of DevToolsFrontendHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_FRONTEND_H_ 5 #ifndef CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_FRONTEND_H_
6 #define CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_FRONTEND_H_ 6 #define CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_FRONTEND_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "base/memory/scoped_ptr.h" 11 #include "base/memory/scoped_ptr.h"
12 #include "content/public/browser/devtools_agent_host.h" 12 #include "content/public/browser/devtools_agent_host.h"
13 #include "content/public/browser/devtools_client_host.h" 13 #include "content/public/browser/devtools_client_host.h"
14 #include "content/public/browser/devtools_frontend_host_delegate.h" 14 #include "content/public/browser/devtools_frontend_host.h"
15 #include "content/public/browser/web_contents_observer.h" 15 #include "content/public/browser/web_contents_observer.h"
16 16
17 namespace content { 17 namespace content {
18 18
19 GURL GetDevToolsPathAsURL(const std::string& settings, 19 GURL GetDevToolsPathAsURL(const std::string& settings,
20 const std::string& frontend_url); 20 const std::string& frontend_url);
21 21
22 class RenderViewHost; 22 class RenderViewHost;
23 class Shell; 23 class Shell;
24 class WebContents; 24 class WebContents;
25 25
26 class ShellDevToolsFrontend : public WebContentsObserver, 26 class ShellDevToolsFrontend : public WebContentsObserver,
27 public DevToolsFrontendHostDelegate { 27 public DevToolsFrontendHost::Delegate,
28 public DevToolsClientHost {
28 public: 29 public:
29 static ShellDevToolsFrontend* Show(WebContents* inspected_contents); 30 static ShellDevToolsFrontend* Show(WebContents* inspected_contents);
30 static ShellDevToolsFrontend* Show(WebContents* inspected_contents, 31 static ShellDevToolsFrontend* Show(WebContents* inspected_contents,
31 const std::string& settings, 32 const std::string& settings,
32 const std::string& frontend_url); 33 const std::string& frontend_url);
33 void Activate(); 34 void Activate();
34 void Focus(); 35 void Focus();
35 void InspectElementAt(int x, int y); 36 void InspectElementAt(int x, int y);
36 void Close(); 37 void Close();
37 38
38 Shell* frontend_shell() const { return frontend_shell_; } 39 Shell* frontend_shell() const { return frontend_shell_; }
39 40
40 private: 41 private:
41 ShellDevToolsFrontend(Shell* frontend_shell, DevToolsAgentHost* agent_host); 42 ShellDevToolsFrontend(Shell* frontend_shell, DevToolsAgentHost* agent_host);
42 virtual ~ShellDevToolsFrontend(); 43 virtual ~ShellDevToolsFrontend();
43 44
44 // WebContentsObserver overrides 45 // WebContentsObserver overrides
45 virtual void RenderViewCreated(RenderViewHost* render_view_host) OVERRIDE; 46 virtual void RenderViewCreated(RenderViewHost* render_view_host) OVERRIDE;
46 virtual void DocumentOnLoadCompletedInMainFrame() OVERRIDE; 47 virtual void DocumentOnLoadCompletedInMainFrame() OVERRIDE;
47 virtual void WebContentsDestroyed() OVERRIDE; 48 virtual void WebContentsDestroyed() OVERRIDE;
48 virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE; 49 virtual void RenderProcessGone(base::TerminationStatus status) OVERRIDE;
49 50
50 // DevToolsFrontendHostDelegate implementation 51 // content::DevToolsFrontendHost::Delegate implementation.
51 virtual void DispatchOnEmbedder(const std::string& message) OVERRIDE {} 52 virtual void HandleMessageFromDevToolsFrontend(
53 const std::string& message) OVERRIDE {}
54 virtual void HandleMessageFromDevToolsFrontendToBackend(
55 const std::string& message) OVERRIDE;
52 56
57 // content::DevToolsClientHost implementation.
58 virtual void DispatchOnInspectorFrontend(const std::string& message) OVERRIDE;
53 virtual void InspectedContentsClosing() OVERRIDE; 59 virtual void InspectedContentsClosing() OVERRIDE;
60 virtual void ReplacedWithAnotherClient() OVERRIDE {}
54 61
55 Shell* frontend_shell_; 62 Shell* frontend_shell_;
56 scoped_refptr<DevToolsAgentHost> agent_host_; 63 scoped_refptr<DevToolsAgentHost> agent_host_;
57 scoped_ptr<DevToolsClientHost> frontend_host_; 64 scoped_ptr<DevToolsFrontendHost> frontend_host_;
58 65
59 DISALLOW_COPY_AND_ASSIGN(ShellDevToolsFrontend); 66 DISALLOW_COPY_AND_ASSIGN(ShellDevToolsFrontend);
60 }; 67 };
61 68
62 } // namespace content 69 } // namespace content
63 70
64 #endif // CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_FRONTEND_H_ 71 #endif // CONTENT_SHELL_BROWSER_SHELL_DEVTOOLS_FRONTEND_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698