scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json - Issue 427073003: Adds ability to filter the set of tests that are run by a bot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json

Issue 427073003: Adds ability to filter the set of tests that are run by a bot (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: fix Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipes/chromium_trybot.py ('K') | « scripts/slave/recipes/chromium_trybot.py ('k') | scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json

diff --git a/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json b/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json

index 9a5801d58cb474bf6f25099c7a56752ff9d04537..08757146cd27ad5fbb176b1022c82c9a8b9d0644 100644

--- a/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json

+++ b/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json

@@ -96,11 +96,18 @@

"python",

"-u",

"[SLAVE_BUILD]/src/build/gyp_chromium",

- "--analyzer",

- "foo.cc"

+ "--analyzer2",

iannucci 2014/07/30 01:20:37 is the analyzer2 syntax extensible enough that you

sky 2014/07/30 21:14:16 The reason I went with analyzer2 here is to suppor

+ "{\"files\": [\"foo.cc\"], \"targets\": []}"

"name": "analyze",

- "stdout": "/path/to/tmp/"

+ "stdout": "/path/to/tmp/json",

+ "~followup_annotations": [

+ "@@@STEP_LOG_LINE@json.output@{@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"status\": \"Found dependency\", @@@",

+ "@@@STEP_LOG_LINE@json.output@ \"targets\": []@@@",

+ "@@@STEP_LOG_LINE@json.output@}@@@",

+ "@@@STEP_LOG_END@json.output@@@"

+ ]

{

"cmd": [